AB infrastructure #357
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // | ||
| // ABSocialAuthString.swift | ||
| // Stepic | ||
| // | ||
| // Created by Ostrenkiy on 04.09.2018. | ||
| // Copyright © 2018 Alex Karpov. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import UIKit | ||
|
|
||
| class ABSocialAuthString: ActiveABTest { | ||
| let ID = "ab_social_auth_string" | ||
|
|
||
|
|
||
| let controlValue: String = NSLocalizedString("SignInTitleSocial", comment: "") | ||
|
|
||
|
|
||
| func value(group: String) -> String? { | ||
| switch group { | ||
| case "control": | ||
| return controlValue | ||
|
There was a problem hiding this comment. Предлагаю начать указывать явно |
||
| case "test": | ||
| return NSLocalizedString("SignInTitleSocialTest", comment: "") | ||
| default: | ||
| return nil | ||
|
There was a problem hiding this comment. Смысл делать There was a problem hiding this comment. А еще можно строки превратить в enum, где для всех неизвестных значений будет определяться кейс |
||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // | ||
| // ABTestService.swift | ||
| // Stepic | ||
| // | ||
| // Created by Ostrenkiy on 03.09.2018. | ||
| // Copyright © 2018 Alex Karpov. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| protocol ActiveABTest { | ||
|
|
||
| associatedtype ValueType | ||
| var ID: String { get } | ||
| func value(group: String) -> ValueType? | ||
| var controlValue: ValueType { get } | ||
|
There was a problem hiding this comment. Почему бы не добавить сюда еще |
||
| } | ||
|
|
||
| class ABTestService<T: ActiveABTest> { | ||
|
|
||
| var test: T | ||
|
|
||
| private let defaults = UserDefaults.standard | ||
|
|
||
| init(test: T) { | ||
| self.test = test | ||
| } | ||
|
|
||
| var value: T.ValueType { | ||
| if let resultGroup = RemoteConfig.shared.string(forKey: test.ID + "_result") { | ||
|
There was a problem hiding this comment. if let resultGroup = RemoteConfig.shared.string(forKey: test.ID + "_result"),
!resultGroup.isEmpty {
defaults.set(resultGroup, forKey: test.ID)
return test.value(group: resultGroup) ?? test.controlValue
}Без лишней вложенности. |
||
| if !resultGroup.isEmpty { | ||
| defaults.set(resultGroup, forKey: test.ID) | ||
| return test.value(group: resultGroup) ?? test.controlValue | ||
| } | ||
| } | ||
| if let group = defaults.value(forKey: test.ID) as? String { | ||
| return test.value(group: group) ?? test.controlValue | ||
| } else { | ||
| if RemoteConfig.shared.fetchComplete { | ||
| guard | ||
| let group = RemoteConfig.shared.string(forKey: test.ID), | ||
|
There was a problem hiding this comment. Давай не будем изобретать новое форматирование длинных гвардов |
||
| let value = test.value(group: group) | ||
| else { | ||
| return test.controlValue | ||
| } | ||
| defaults.set(group, forKey: test.ID) | ||
| AnalyticsUserProperties.shared.setAmplitudeProperty(key: test.ID, value: group) | ||
| return value | ||
| } else { | ||
| return test.controlValue | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай помечать класс как
final, если не планируется от него наследоваться