Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar model #697

Merged
merged 33 commits into from
Oct 30, 2024
Merged

Calendar model #697

merged 33 commits into from
Oct 30, 2024

Conversation

tymmesyde
Copy link
Member

No description provided.

elpiel and others added 20 commits June 11, 2024 17:42
@elpiel
feat(calendar): constants - Add calendar storage key, max calendar it…
e11d987 
…ems & Extra Prop

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(calendar): action - PullCalendar
a3b0a0b 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(calendar): CalendarBucket & CalendarItem
025e254 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(calendar): Push Calendar Event & Internal PullCalendar & Calenda…
c1836ed 
…rChanged

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(calendar): Ctx - update_calendar
f948ff8 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
docs(notifs): NotificationsBucket - Add docs
61b8a1a 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
fix: tests
cc6ca85 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: Fix docs and extract constants
2e623f0 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat: Calendar model
63df83d 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: Update docs
067d07e 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: Calendar model - flatten CalendarBucket
caf8677 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@tymmesyde
feat: impl calendar model
17bfad5
@tymmesyde
test(calendar): add load action unit test for calendar
b2742bd
@tymmesyde
fix(calendar): return only items added to library
5a2cf79
@tymmesyde
test(calendar): fmt
5db1bc3
@tymmesyde
refactor(deep_links): simplify CalendarDeepLinks From impl
00d0a6a
@tymmesyde
feat(calendar): return today in month_info
6159ef2
@tymmesyde
refactor(calendar): remove selectable effects in resource request result
a82e55d
@tymmesyde
fix(calendar): fmt
5c91660
@tymmesyde
refactor(runtime): remove unused messages
fcb0b66
@tymmesyde tymmesyde requested a review from elpiel June 24, 2024 12:13
This was referenced Jul 24, 2024
Closed
Merged
@TRtomasz
Copy link
Member

imo no point of making a pr that does not include all needed dependencies to run. It is untestable. I this case it should include in package.json core-web version that is still in PR without waiting for it to be merged. Preferred solution would be to make this pr only after core and core-web changes are merged so we could avoid testing something without a reason in case it is decided that core/core-web changes should be rewritten or changed in a bigger part.

@elpiel
Copy link
Member

elpiel commented Sep 19, 2024

There are a few things in the PR that I would like to change. Especially with handling the Date changes and date changes with offset. I've worked on some of the changes but left it as I had to work on more pressing issues.

Will get back to this.

elpiel
elpiel requested changes Oct 25, 2024
View reviewed changes
src/models/calendar.rs Outdated
}
}

impl From<NaiveDate> for Date {
Copy link
Member

@elpiel elpiel Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing. NaiveDate also has a day. Why is it different that the DateTime?

  • Please handle Day vs Month values differently

src/models/calendar.rs Show resolved Hide resolved
src/models/calendar.rs Outdated Show resolved Hide resolved
@elpiel
Copy link
Member

elpiel commented Oct 25, 2024

I will still test the stremio-web for the UI implementation and general workings of the logic but there are a few things that need refactoring from the model.
Logic looks good so far though.

elpiel
elpiel reviewed Oct 25, 2024
View reviewed changes
src/models/calendar.rs Outdated Show resolved Hide resolved
elpiel
elpiel reviewed Oct 25, 2024
View reviewed changes
src/models/calendar.rs Outdated Show resolved Hide resolved
@elpiel elpiel merged commit f063177 into development Oct 30, 2024
3 checks passed
@elpiel elpiel deleted the feat/calendar-model branch October 30, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tymmesyde @TRtomasz @elpiel