Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: streaming-server urls bucket #724

Merged
merged 47 commits into from
Nov 28, 2024
Merged

feat: streaming-server urls bucket #724

merged 47 commits into from
Nov 28, 2024

Conversation

kKaskak
Copy link
Member

@kKaskak kKaskak commented Oct 3, 2024 •
edited
Loading

No description provided.

@kKaskak kKaskak requested a review from elpiel October 3, 2024 11:12
@kKaskak kKaskak requested a review from tymmesyde October 3, 2024 11:25
kKaskak added 23 commits October 3, 2024 14:30
@kKaskak
chore(fmt): fmt --all
d8a8240
@kKaskak
delete: comments
5bee75a
@kKaskak
refactor: rename base item variable
67baef4
@kKaskak
refactor: use chrono for timestamps
18c06a1
@kKaskak
refactor: rename bucket
698c83e
@kKaskak
refactor: bucket logic
84f4dc2
@kKaskak
refactor: use anyhow for better err handling
f1c0224
@kKaskak
refactor: impl update_server_urls
768a432
@kKaskak
refactor: bucket logic
142591d
@kKaskak
remove: serverurl bucket from server_settings
eae1404
@kKaskak
refactor: model seralization
4c449ef
@kKaskak
refactor: remove unecessary logic
bbb638f
@kKaskak
remove: selected field in ServerUrlItem
662672c
@kKaskak
chore(fmt): fmt
3a09e3a
@kKaskak
add: ctx serialization for server_urls
c0b638c
@kKaskak
add: migation to v15
4fccc7e
@kKaskak
chore: fmt
5743f34
@kKaskak
rename: var streaming_server_urls
8366e31
@kKaskak
chore: fmt & clippy
c6f5405
@kKaskak
fix: env storage key missmatch
4fa6ffd
@kKaskak
feat: tests
1cf708f
@kKaskak
remove: unnecessary bucket result
784a00f
@kKaskak
refactor: serialization of streaming_server_urls
23a04e4
@kKaskak kKaskak mentioned this pull request Oct 9, 2024
Merged
2 tasks
@kKaskak kKaskak requested review from tymmesyde and elpiel October 23, 2024 14:32
elpiel
elpiel reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few things to take into account.
Will test the UI now

stremio-core-web/src/model/serialize_ctx.rs Outdated Show resolved Hide resolved
stremio-core-web/src/model/serialize_ctx.rs Outdated Show resolved Hide resolved
src/models/ctx/update_streaming_server_urls.rs Outdated Show resolved Hide resolved
src/types/server_urls/server_urls_bucket.rs Show resolved Hide resolved
@kKaskak kKaskak requested a review from elpiel October 24, 2024 07:42
@kKaskak kKaskak requested a review from elpiel November 14, 2024 11:46
@kKaskak kKaskak self-assigned this Nov 24, 2024
@kKaskak kKaskak added the enhancement New feature or request label Nov 24, 2024
@elpiel elpiel merged commit 4a6cfe8 into development Nov 28, 2024
5 checks passed
@elpiel elpiel deleted the feat/streming-server-urls-bucket branch November 28, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel approved these changes

@tymmesyde tymmesyde Awaiting requested review from tymmesyde

Assignees

@kKaskak kKaskak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kKaskak @tymmesyde @elpiel