Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Manage multiple streaming URLs in the Settings #707

Merged
merged 41 commits into from
Dec 3, 2024
Merged

Feat: Manage multiple streaming URLs in the Settings #707

merged 41 commits into from
Dec 3, 2024

Conversation

kKaskak
Copy link
Member

@kKaskak kKaskak commented Oct 9, 2024 •
edited
Loading

@kKaskak kKaskak marked this pull request as draft October 9, 2024 11:13
@kKaskak kKaskak marked this pull request as ready for review October 21, 2024 14:13
@kKaskak kKaskak changed the title Feat: Manage multiple streaming URLs in the Settings [WIP] Feat: Manage multiple streaming URLs in the Settings Oct 22, 2024
@kKaskak kKaskak requested review from tymmesyde and elpiel October 22, 2024 08:23
@kKaskak kKaskak added the enhancement New feature or request label Oct 22, 2024
elpiel
elpiel previously approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment •
edited by kKaskak
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes:

  • I haven't checked whether JS Url aligns with the rust crate impl url::Url so not sure about validation edge cases
  • Basic functionality works and it validates URL + adds/removes urls
  • _mtime needs to be renamed
  • fix build (lints)

@kKaskak kKaskak requested a review from elpiel October 24, 2024 07:32
@kKaskak kKaskak requested review from tymmesyde and elpiel November 29, 2024 10:23
@kKaskak
Copy link
Member Author

kKaskak commented Nov 30, 2024

@tymmesyde Ready for merge ✅

elpiel
elpiel previously approved these changes Dec 2, 2024
View reviewed changes
@tymmesyde tymmesyde merged commit d3dec89 into development Dec 3, 2024
1 check passed
@kKaskak kKaskak linked an issue Dec 3, 2024 that may be closed by this pull request
[Feature] Stremio Server Switch as Dropdown #611
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tymmesyde tymmesyde tymmesyde approved these changes

@elpiel elpiel elpiel left review comments

Assignees

@kKaskak kKaskak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Stremio Server Switch as Dropdown
3 participants
@kKaskak @tymmesyde @elpiel