Add test for repeated "import" (clone and pull) from git #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplaice
changed the title
aplaice
force-pushed
the
git_import_test
branch
2 times, most recently
from
69af6f8 to
1bd455c
Compare
aplaice
force-pushed
the
git_import_test
branch
2 times, most recently
from
11a91a7 to
50e42e8
Compare
Diagnose Stvad#138 which occurred on Windows. (A lock for the git pack file is often held by a previous clone/pull and not released, so the next pull fails (`PermissionError`).) The monkey-patching of `get_repo_local_path` is ugly, but far less complex than partially mocking ConfigSettings. Alternatively, we could have modified `get_repo_local_path` to have an extra, optional argument (say `full_snapshot_path` that'd override the config call), but modifying the code to fit the test is also ugly.
aplaice
force-pushed
the
git_import_test
branch
from
50e42e8 to
b4a1a1c
Compare
This was referenced Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose #138 which occurred on Windows. (A lock for the git pack file is often held by a previous clone/pull and not released, so the next pull fails (
PermissionError).)Without the fix from #139, the test indeed fails (as expected/desired)! (See aplaice#2.)
With the fix from #139, the test indeed succeeds (as expected/desired)! (See aplaice#3.)
I'll leave all these PRs open for several days in case there are comments and if not, carefully merge them in the right order (fixes to tests, tests, GitHub actions?, fixes).
Edit: I added GitHub actions before the new test, to double-check that the new test fails on Windows, in the final configuration, not just with my haphazard set of commits, in the fork.
I'm not too happy with the precise implementation of this test, so I'll leave it for a couple of days, in case I can think of some improvements.