Git import test with GitHub actions #2

aplaice · 2021-11-20T18:05:18Z

No description provided.

Fix Stvad#147. Unlike Linux, Windows doesn't allow ASCII control characters (codepoint < 32) in filenames. See: https://stackoverflow.com/a/31976060/6598435 https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions For consistency, we should remove them always. This might be a moot issue, since in recent versions of Anki (2.1.43 tested) it seems that all such control characters (including \n) are already filtered out from deck names, but I don't think it hurts. \n will be double-counted, but I think it's best to keep it explicitly for readability (and since we're using a set, duplication doesn't matter). The `join` takes just 5 μs, so I think replacing it with the "computed" string is not worth the drop in readability.

Also, reduce "on". (No need to duplicate.)

aplaice · 2021-11-20T18:09:24Z

Hurrah! The Windows test failed (as desired):

....................F..***.........

1 examples failed of 32 ran in 2.1955 seconds

Failures:

  1) GitImporter user is trying to import a deck from a git repo multiple times it should clone the git repo without crashing
     Failure/Error: test\github\github_importer_spec.py subject.clone_repository_and_import("https://github.com/aplaice/colemak_keyboard_layout_dynamic")
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
         PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: '\\tmp\\foo\\bar\\.git\\objects\\pack\\pack-da39a3ee5e6b4b0d3255bfef95601890afd80709.pack'
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
             
     File "C:\Users\runneradmin\.virtualenvs\CrowdAnki-N-R4mrsk\lib\site-packages\dulwich\object_store.py", line 724, in _complete_thin_pack
         os.remove(target_pack)
     File "C:\Users\runneradmin\.virtualenvs\CrowdAnki-N-R4mrsk\lib\site-packages\dulwich\object_store.py", line 765, in add_thin_pack
         return self._complete_thin_pack(f, path, copier, indexer)
     File "C:\Users\runneradmin\.virtualenvs\CrowdAnki-N-R4mrsk\lib\site-packages\dulwich\client.py", line 416, in commit
         target.object_store.add_thin_pack(f.read, None)
     File "C:\Users\runneradmin\.virtualenvs\CrowdAnki-N-R4mrsk\lib\site-packages\dulwich\client.py", line 430, in fetch
         commit()
     File "C:\Users\runneradmin\.virtualenvs\CrowdAnki-N-R4mrsk\lib\site-packages\dulwich\porcelain.py", line 962, in pull
         path, r, progress=errstream.write, determine_wants=determine_wants)
     File ".\crowd_anki\github\github_importer.py", line 39, in clone_repository_and_import
         porcelain.pull(porcelain.open_repo(str(repo_local_path)), repo_url)
     File "test\github\github_importer_spec.py", line 21, in 00000029__it should clone the git repo without crashing
         subject.clone_repository_and_import("https://github.com/aplaice/colemak_keyboard_layout_dynamic")
     
     
Error: Process completed with exit code 1.

aplaice added 14 commits November 20, 2021 17:28

Add rudimentary, experimental workflow

fa99e59

Try windows

f60bfb3

Also, reduce "on". (No need to duplicate.)

Ensure installation of pure dulwich

54ce025

Set default shell to bash (for <())

a571b38

Try preventing concurrency?

2fc9371

Try preventing concurrency with sleep (hack!!)

6fd3ccc

Try separating out steps to avoid concurrency

b6bbe4c

Add step to "initialise" pipenv

4512dd1

Write requirements to file

6e0e429

Install only dulwich from requirements.txt

27a250d

Clean up

c9eb339

Run on both Ubuntu and Windows

6b38884

WIP Git test import crash on windows

144c1e7

aplaice mentioned this pull request Nov 20, 2021

Add test for repeated "import" (clone and pull) from git Stvad/CrowdAnki#150

Merged

aplaice closed this Dec 2, 2021

aplaice deleted the git_import_test_with_github_actions branch December 2, 2021 21:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Git import test with GitHub actions #2

Git import test with GitHub actions #2

aplaice commented Nov 20, 2021

aplaice commented Nov 20, 2021

Git import test with GitHub actions #2

Git import test with GitHub actions #2

Conversation

aplaice commented Nov 20, 2021

aplaice commented Nov 20, 2021