You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like the latest version enabled some LSP features previously not supported, and a handler (in this case textDocument/diagnostic) returning an empty struct instead of null once again coming back to bite us. In our defence though, this is not a case where the specification defines null as a valid response! That and the fact that our response has been handled well by all other clients we've tried suggests that it's probably Neovim getting things wrong here. Perhaps they'll fix that later as I'm sure they'll find issues with other servers too. But no matter who's wrong, it seems like all the clients I've tried accept null as a response too, so we can probably just make that change.
While the specification isn't clear here, Neovim apparently had issues
dealing with the empty object response. And since all the other editors
seem to handle a null response too, let's just go with that instead.
Fixes#810
Signed-off-by: Anders Eknert <anders@styra.com>
While the specification isn't clear here, Neovim apparently had issues
dealing with the empty object response. And since all the other editors
seem to handle a null response too, let's just go with that instead.
Fixes#810
Signed-off-by: Anders Eknert <anders@styra.com>
* Support ignore directives in aggregate rules
Also some light refactoring, but should hopefully not
be too distracting.
FixesStyraInc#803
Signed-off-by: Anders Eknert <anders@styra.com>
* Return `null` in textDocument/diagnostic handler (StyraInc#812)
While the specification isn't clear here, Neovim apparently had issues
dealing with the empty object response. And since all the other editors
seem to handle a null response too, let's just go with that instead.
FixesStyraInc#810
Signed-off-by: Anders Eknert <anders@styra.com>
---------
Signed-off-by: Anders Eknert <anders@styra.com>
See: #578 (comment)
Looks like the latest version enabled some LSP features previously not supported, and a handler (in this case
textDocument/diagnostic
) returning an empty struct instead ofnull
once again coming back to bite us. In our defence though, this is not a case where the specification definesnull
as a valid response! That and the fact that our response has been handled well by all other clients we've tried suggests that it's probably Neovim getting things wrong here. Perhaps they'll fix that later as I'm sure they'll find issues with other servers too. But no matter who's wrong, it seems like all the clients I've tried acceptnull
as a response too, so we can probably just make that change.Thanks @folliehiyuki for reporting this.
The text was updated successfully, but these errors were encountered: