Return null in textDocument/diagnostic handler
#812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the specification isn't clear here, Neovim apparently had issues dealing with the empty object response. And since all the other editors seem to handle a null response too, let's just go with that instead. Fixes #810 Signed-off-by: Anders Eknert <anders@styra.com>
|
I've tried this branch and can confirm that Neovim could handle the response gracefully. The reported error message doesn't pop up anymore. |
|
@folliehiyuki thanks! |
charlieegan3
approved these changes
Jun 10, 2024
anderseknert
added a commit
that referenced
this pull request
Jun 10, 2024
* Support ignore directives in aggregate rules Also some light refactoring, but should hopefully not be too distracting. Fixes #803 Signed-off-by: Anders Eknert <anders@styra.com> * Return `null` in textDocument/diagnostic handler (#812) While the specification isn't clear here, Neovim apparently had issues dealing with the empty object response. And since all the other editors seem to handle a null response too, let's just go with that instead. Fixes #810 Signed-off-by: Anders Eknert <anders@styra.com> --------- Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* Support ignore directives in aggregate rules Also some light refactoring, but should hopefully not be too distracting. Fixes StyraInc#803 Signed-off-by: Anders Eknert <anders@styra.com> * Return `null` in textDocument/diagnostic handler (StyraInc#812) While the specification isn't clear here, Neovim apparently had issues dealing with the empty object response. And since all the other editors seem to handle a null response too, let's just go with that instead. Fixes StyraInc#810 Signed-off-by: Anders Eknert <anders@styra.com> --------- Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the specification isn't clear here, Neovim apparently had issues dealing with the empty object response. And since all the other editors seem to handle a null response too, let's just go with that instead.
Fixes #810