-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate Text
field value in default pretty reporter when needed
#936
Labels
good first issue
Good for newcomers
Comments
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Jul 25, 2024
Fixes StyraInc#936 Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
pushed a commit
to charlieegan3/regal
that referenced
this issue
Jul 25, 2024
Fixes StyraInc#936 Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
added a commit
that referenced
this issue
Jul 29, 2024
Fixes #936 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
Jul 29, 2024
Fixes #936 Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this issue
Oct 1, 2024
* reporter: Trim long lines of location text Fixes StyraInc#936 Signed-off-by: Charlie Egan <charlie@styra.com> * reporter: Limit pretty lines at 120 chars instead Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When violations occur on some very long lines, the pretty reporter prints it in its entirety under the
Text
attribute. This can cause the terminal output to be wrapped, which makes everything look bad. The following screenshot demonstrates this:This is the rule that caused this. The wrapping however taints all violations, and not just the one that contained a long line.
We should truncate the output of the
Text
field to max 120 characters, as that's the default max line length recommendation.The text was updated successfully, but these errors were encountered: