feat: algo to function in substratools #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaultFy
requested review from
Esadruhn,
louishulot,
samlesu,
alexisdeh and
RomainGoussault
as code owners
ThibaultFy
changed the title
This was referenced Oct 7, 2022
ThibaultFy
force-pushed
the
gt/class_to_function
branch
2 times, most recently
from
4e0885f to
da69950
Compare
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
ThibaultFy
force-pushed
the
gt/class_to_function
branch
from
da69950 to
51d8c58
Compare
Comment on lines
175
to
+176
| if __name__ == "__main__": | ||
| tools.algo.execute(Algo()) | ||
| tools.execute(train, predict) |
There was a problem hiding this comment.
What do we need that now that we specify the entrypoint?
There was a problem hiding this comment.
We need to pass the functions we want to register to substratools.
A new interface will be proposed very soon (like in the afternoon) to use decorator to register the functions, and have only tools.execute() without arguments
RomainGoussault
approved these changes
Oct 11, 2022
davidendico-owkin
pushed a commit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com> Signed-off-by: David ENDICO <david.endico@owkin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: