-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: algo to function in substratools #303
Conversation
9174ada
to
8456ec1
Compare
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
29bce2f
to
00835a2
Compare
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
CHANGELOG.md
Outdated
@@ -98,7 +102,7 @@ compute_plan = client.add_compute_plan( | |||
- used openers within the library only exposes `get_data` and `fake_data` methods due to breaking changes within | |||
substra-tools | |||
- a third argument `task_properties` (containing the `rank` of a task) has been added to all algo methods relying on substra-tools | |||
- substra tools metrics `tools.Metrics` become `tools.MetricAlgo` and `tools.metrics.execute` becomes `tools.algo.execute` (#290) | |||
- substra tools metrics `tools.Metrics` become `tools.MetricAlgo` and `tools.metrics.execute` becomes `tools.execute` (#290) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to add a line in unreleased as it was released that way in 0.39
DEFAULT_SUBSTRATOOLS_VERSION = ( | ||
f"latest-nvidiacuda11.6.0-base-ubuntu20.04-python{sys.version_info.major}.{sys.version_info.minor}-minimal" | ||
) | ||
DEFAULT_SUBSTRATOOLS_VERSION = "class-to-function" # TODO: change before merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- .
tests/test_cli.py
Outdated
@@ -73,8 +73,8 @@ def test_command_config(workdir): | |||
assert list(cfg.keys()) == expected_profiles | |||
|
|||
|
|||
def mock_client_call(mocker, method_name, response="", side_effect=None): | |||
return mocker.patch(f"substra.cli.interface.Client.{method_name}", return_value=response, side_effect=side_effect) | |||
def mock_client_call(mocker, function_name, response="", side_effect=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not related to substratools
CHANGELOG.md
Outdated
@@ -98,7 +102,7 @@ compute_plan = client.add_compute_plan( | |||
- used openers within the library only exposes `get_data` and `fake_data` methods due to breaking changes within | |||
substra-tools | |||
- a third argument `task_properties` (containing the `rank` of a task) has been added to all algo methods relying on substra-tools | |||
- substra tools metrics `tools.Metrics` become `tools.MetricAlgo` and `tools.metrics.execute` becomes `tools.algo.execute` (#290) | |||
- substra tools metrics `tools.Metrics` become `tools.MetricAlgo` and `tools.metrics.execute` becomes `tools.execute` (#290) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not change the previous changelog entries
CHANGELOG.md
Outdated
@@ -535,5 +539,4 @@ client1_org_id = clients[0].organization_info().organization_id | |||
|
|||
## [0.10.0](https://github.com/Substra/substra/releases/tag/0.10.0) - 2021-08-05 | |||
|
|||
[0.10.0]: https://github.com/Substra/substra/compare/0.9.0...0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's deleted by my autosave lint... Don't know why sorry about that
Signed-off-by: ThibaultFy 50656860+ThibaultFy@users.noreply.github.com
Companion PR:
Related issue
#
followed by the number of the issueSummary
Notes
Please check if the PR fulfills these requirements