Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permissions inconsistency in local mode #348

Merged
merged 2 commits into from
Feb 28, 2023
Merged

fix: permissions inconsistency in local mode #348

merged 2 commits into from
Feb 28, 2023

Conversation

ThibaultFy
Copy link
Member

Related issue

# followed by the number of the issue

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@ThibaultFy
fix: permissions modified inplace
7cab40a 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy changed the title fix: permissions modified inplace fix: permissions inconsistency in local mode Feb 27, 2023
@ThibaultFy
changelog
88011b9 
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
@ThibaultFy ThibaultFy marked this pull request as ready for review February 27, 2023 15:33
@ThibaultFy ThibaultFy requested a review from a team as a code owner February 27, 2023 15:33
guilhem-barthes
guilhem-barthes approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThibaultFy ThibaultFy merged commit 7b46bd7 into main Feb 28, 2023
@ThibaultFy ThibaultFy deleted the fix/permission-inplace-modification branch February 28, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

@oleobal oleobal Awaiting requested review from oleobal oleobal is a code owner automatically assigned from Substra/code-owners

@Milouu Milouu Awaiting requested review from Milouu Milouu is a code owner automatically assigned from Substra/code-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThibaultFy @guilhem-barthes