fix: permissions inconsistency in local mode

CHANGELOG.md

@@ -10,7 +10,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - BREAKING: rename Algo to Function ([#341](https://github.com/Substra/substra/pull/341))
-- Rename fields in Performances model (#344)
+- Rename fields in Performances model ([#344](https://github.com/Substra/substra/pull/344))
+
+### Fixed
+
+- Permissions inconsistency in local mode ([#348](https://github.com/Substra/substra/pull/348))
 
 ## [0.42.0](https://github.com/Substra/substra/releases/tag/0.42.0) - 2023-02-20
 

substra/sdk/backends/local/backend.py

@@ -171,12 +171,13 @@ def __compute_permissions(self, permissions):
         If the permissions are private, the active organization is
         in the authorized ids.
         """
+        updated_permissions = copy.deepcopy(permissions)
         owner = self._org_id
-        if permissions.public:
-            permissions.authorized_ids = list()
-        elif not permissions.public and owner not in permissions.authorized_ids:
-            permissions.authorized_ids.append(owner)
-        return permissions
+        if updated_permissions.public:
+            updated_permissions.authorized_ids = list()
+        elif not updated_permissions.public and owner not in updated_permissions.authorized_ids:
+            updated_permissions.authorized_ids.append(owner)
+        return updated_permissions
 
     def __add_compute_plan(
         self,

tests/sdk/local/test_debug.py

@@ -1,3 +1,4 @@
+import copy
 import uuid
 
 import docker
@@ -43,7 +44,6 @@ def test_client_tmp_dir(self, clients):
 
     @pytest.mark.parametrize("dockerfile_type", ("BAD_ENTRYPOINT", "NO_ENTRYPOINT", "NO_FUNCTION_NAME"))
     def test_client_bad_dockerfile(self, asset_factory, dockerfile_type, clients):
-
         client = clients[0]
 
         dataset_query = asset_factory.create_dataset()
@@ -287,6 +287,30 @@ def test_add_compute_plan_with_wrong_metadata(self, clients):
                 )
             )
 
+    def test_permissions_consistency_add_dataset(self, clients, asset_factory):
+        client = clients[0]
+
+        permissions = substra.sdk.schemas.Permissions(public=False, authorized_ids=["foo"])
+        copy_permissions = copy.deepcopy(permissions)
+
+        dataset_query = asset_factory.create_dataset(permissions=permissions)
+
+        client.add_dataset(dataset_query)
+
+        assert str(copy_permissions) == str(permissions)
+
+    def test_permissions_consistency_add_function(self, clients, asset_factory):
+        client = clients[0]
+
+        permissions = substra.sdk.schemas.Permissions(public=False, authorized_ids=["foo"])
+        copy_permissions = copy.deepcopy(permissions)
+
+        function_query = asset_factory.create_function(permissions=permissions)
+
+        client.add_function(function_query)
+
+        assert str(copy_permissions) == str(permissions)
+
     def test_live_performances_json_file_exist(self, asset_factory, clients):
         """Assert the performances file is well created."""
         client = clients[0]
@@ -612,14 +636,12 @@ def test_task_different_owner_dataset(asset_factory, clients):
 
 class TestMultipleOrgLocalClient:
     def test_local_org_info(self, docker_clients):
-
         org1info = docker_clients[0].organization_info()
         org2info = docker_clients[1].organization_info()
 
         assert org1info.organization_id != org2info.organization_id
 
     def test_list_org(self, docker_clients):
-
         org1_id = docker_clients[0].organization_info().organization_id
         org2_id = docker_clients[1].organization_info().organization_id
 
@@ -634,7 +656,6 @@ def test_list_org(self, docker_clients):
         assert not org2[0].is_current
 
     def test_local_org_owner(self, asset_factory, docker_clients):
-
         client = docker_clients[0]
         dataset_query = asset_factory.create_dataset()
         dataset_key = client.add_dataset(dataset_query)
@@ -643,7 +664,6 @@ def test_local_org_owner(self, asset_factory, docker_clients):
         assert dataset.owner == client.organization_info().organization_id
 
     def test_local_org_shared_db(self, asset_factory, docker_clients):
-
         dataset_query = asset_factory.create_dataset()
         dataset_key = docker_clients[0].add_dataset(dataset_query)