Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup interview: Use action syntax to avoid testing tags #537

Closed
plocket opened this issue Mar 29, 2022 · 2 comments
Closed

Setup interview: Use action syntax to avoid testing tags #537

plocket opened this issue Mar 29, 2022 · 2 comments
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.

Comments

@plocket
Copy link
Collaborator

plocket commented Mar 29, 2022

GitHub tags act as if they're branches being pushed. They'll start tests. Docassemble doesn't know how to pull in that kind of thing, or maybe that branch gets immediately deleted or something (at least on AssemblyLine core) and so the tests fail. There's also no reason to test tags as their code is the same as the branch they're for.

Only some repos use tags, but I think we can deal with it pretty easily with the right syntax. I got idea for the below from the conversation in https://github.saobby.my.eu.orgmunity/t/using-on-push-tags-ignore-and-paths-ignore-together/16931/2:

push:
  branches:
    - "**"
  tags-ignore:
    - "**"

We'll have to test out that syntax somewhere with some github tag releases.

FYI, AssemblyLine's [method of doing this] is working, but it was funky for a while and I'm not convinced it won't become funky again. It's missing the branches part of the above code and that's what may have caused the problem.

@plocket plocket added the enhancement New feature or request label Mar 29, 2022
@BryceStevenWilley
Copy link
Collaborator

Related to #757 and #760.

@plocket
Copy link
Collaborator Author

plocket commented Feb 4, 2024

Was this closed by #823 with #760?

@plocket plocket added the reopen We won't be taking care of this any time soon. label Oct 1, 2024
@plocket plocket closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.
Projects
None yet
Development

No branches or pull requests

2 participants