Close #760, use dainstall so PRs can test too #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hope to avoid npm installing our whole repo and thus being too large to install on the playground
moving moving validation out of its own script which, before this, would run on access to the session vars script as it was imported into the script before any tests ran.
I worked so hard on those...
This was referenced Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have:
Reason for this PR
Allow alkiln to test PRs and such as well. Use our own action to avoid having to update all the time
Links to any solved or related issues
Close #760, close #822
Any manual testing I have done to ensure my PR is working
Command line experiments with
dainstalland such.Notes
Until/unless the PR in docassemblecli is accepted, local development is going to take a bit more setup work and we'll have to update our own README docs.
[Also, I found something somewhere that said that one of our commands (not sure which one) wasn't going to work on windows. Or maybe something in dainstall? I'm not sure what doesn't work or where I found the info. Maybe that problematic code is gone. We need to try the
dainstallflow on a windows computer, though.]