Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ALKiln action work on GitHub tag releases #757

Closed
BryceStevenWilley opened this issue Sep 8, 2023 · 1 comment
Closed

Make ALKiln action work on GitHub tag releases #757

BryceStevenWilley opened this issue Sep 8, 2023 · 1 comment
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.

Comments

@BryceStevenWilley
Copy link
Collaborator

BryceStevenWilley commented Sep 8, 2023

Example of failing test: https://github.com/SuffolkLITLab/docassemble-ALAffidavitOfIndigency/actions/runs/6125747748/job/16628337375.

It looks like we manually ignore tags and don't run workflows on tags in our other repos, but that bit isn't in our suggested workflow example.

This should be an easy fix though, and we could make it in a few places.

  • in action.yml: if we used github.ref_name instead of the current github.ref, we'd get

    The short ref name of the branch or tag that triggered the workflow run. This value matches the branch or tag name shown on GitHub. For example, feature-branch-1.

    This is exactly what docassemble wants. Not sure why it does'n't work with the full version, but it doesn't.

  • a more hacky change with a smaller scope would be to include refs/tags/ in

    branch_name = process.env.BRANCH_PATH.replace( `refs/heads/`, '' );

    I can confirm manually that telling docassemble the tag name works:

    ALKiln debug: Stored name of Project "ALKilnTestdocassembleALAffidavitOfIndigencyv2121694202276108" locally.
    ALKiln : Trying to pull code from the "v2.1.2" branch.
    ALKiln debug: Project name from file is "ALKilnTestdocassembleALAffidavitOfIndigencyv2121694202276108".
    ALKiln : Your Docassemble server finished pulling the package's code. 
    ALKiln setup: Success! Test setup has finished successfully.
    
@plocket plocket changed the title Kiln action doesn't work on tags Make ALKiln action work on tags Sep 20, 2023
@plocket plocket added the enhancement New feature or request label Sep 20, 2023
@plocket
Copy link
Collaborator

plocket commented Feb 4, 2024

Was this closed by #823 with #760?

@plocket plocket changed the title Make ALKiln action work on tags Make ALKiln action work on GitHub tag releases Apr 23, 2024
@plocket plocket added the reopen We won't be taking care of this any time soon. label Oct 2, 2024
@plocket plocket closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.
Projects
None yet
Development

No branches or pull requests

2 participants