Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: split unit tests into their own workflow, run cucumber tests using our action #822

Closed
plocket opened this issue Nov 11, 2023 · 0 comments · Fixed by #823
Closed

Tests: split unit tests into their own workflow, run cucumber tests using our action #822

plocket opened this issue Nov 11, 2023 · 0 comments · Fixed by #823
Labels
enhancement New feature or request testing Tests for this framework

Comments

@plocket
Copy link
Collaborator

plocket commented Nov 11, 2023

We keep having to update our own test workflow file, duplicating the work in action.yml. We should instead just use action.yml in our cucumber tests.
@plocket plocket added testing Tests for this framework enhancement New feature or request labels Nov 12, 2023
plocket added a commit that referenced this issue Nov 12, 2023
@plocket
Split unit tests out, Use our own action, close #822 maybe
3b6507e 
Hope to avoid npm installing our  whole repo and thus being too
large to install on the playground
@plocket plocket mentioned this issue Nov 12, 2023
Merged
3 tasks
plocket added a commit that referenced this issue Nov 14, 2023
@plocket
Close #760, use dainstall so PRs can test too (#823)
d22f239 
* Use `dainstall` to install the package on the playground

* Add more error info to the setup error msg. Where's the piped data?

* Fix typo

* Echo to check if dainstall is there

* Install our _own_ script to install docassemblecli

* Split unit tests out, Use our own action, close #822 maybe

Hope to avoid npm installing our  whole repo and thus being too
large to install on the playground

* Ensure unit tests can run completely indepenent (including env) by

moving moving validation out of its own script which, before this,
would run on access to the session vars script as it was imported
into the script before any tests ran.

* Clean up tests. A few risky cleanups, like moving `@checkout`

* Restore checkout in workflows for relative refs to action.yml files

* Correct typos

* Trigger on pull request to test properly

* Update changelog

* Add to changelog

* Clean up lots of now unused functions

I worked so hard on those...

* Only install python if using docassemblecli

* Clarify comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing Tests for this framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #760, use dainstall so PRs can test too SuffolkLITLab/ALKiln
1 participant
@plocket