Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #760, use dainstall so PRs can test too #823

Merged
merged 16 commits into from
Nov 14, 2023
Merged

Close #760, use dainstall so PRs can test too #823

merged 16 commits into from
Nov 14, 2023

Commits on Nov 11, 2023

  1. Use dainstall to install the package on the playground

    @plocket
    plocket committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    0ebd3e2 View commit details
    Browse the repository at this point in the history

  2. Add more error info to the setup error msg. Where's the piped data?

    @plocket
    plocket committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    37e5a69 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @plocket
    plocket committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    eba8c80 View commit details
    Browse the repository at this point in the history

  4. Echo to check if dainstall is there

    @plocket
    plocket committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    3717216 View commit details
    Browse the repository at this point in the history

  5. Install our _own_ script to install docassemblecli

    @plocket
    plocket committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    12e79c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. Split unit tests out, Use our own action, close #822 maybe 

    Hope to avoid npm installing our  whole repo and thus being too
large to install on the playground
    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    3b6507e View commit details
    Browse the repository at this point in the history

  2. Ensure unit tests can run completely indepenent (including env) by 

    moving moving validation out of its own script which, before this,
would run on access to the session vars script as it was imported
into the script before any tests ran.
    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    25a0128 View commit details
    Browse the repository at this point in the history

  3. Clean up tests. A few risky cleanups, like moving @checkout

    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    5ee4fb8 View commit details
    Browse the repository at this point in the history

  4. Restore checkout in workflows for relative refs to action.yml files

    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    233bc57 View commit details
    Browse the repository at this point in the history

  5. Correct typos

    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    2eacce0 View commit details
    Browse the repository at this point in the history

  6. Trigger on pull request to test properly

    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    a915f58 View commit details
    Browse the repository at this point in the history

  7. Update changelog

    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    5e0c9bb View commit details
    Browse the repository at this point in the history

  8. Add to changelog

    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    4a9ceac View commit details
    Browse the repository at this point in the history

  9. Clean up lots of now unused functions 

    I worked so hard on those...
    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    d7998ca View commit details
    Browse the repository at this point in the history

  10. Only install python if using docassemblecli

    @plocket
    plocket committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    a160831 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Clarify comments

    @plocket
    plocket committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    e3853d1 View commit details
    Browse the repository at this point in the history