Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random input selecting "Back" button? #628

Closed
BryceStevenWilley opened this issue Dec 2, 2022 · 0 comments · Fixed by #633
Closed

Random input selecting "Back" button? #628

BryceStevenWilley opened this issue Dec 2, 2022 · 0 comments · Fixed by #633
Labels
enhancement New feature or request

Comments

@BryceStevenWilley
Copy link
Collaborator

In some simple random input tests, I found the back button was being pressed quite a bit. For example, in AppearanceEfiling, the random test got to the 4th question after the first 3 intro screens (landing screen, introduction screen, and terms of use) 2 times in 25 screens. It would keep pressing back instead of next, since the landing screens only had 2 options to choose from.

We should recognize a few specific buttons on the screen (back, the review sections, etc). and click them at a much lower rate than buttons that advance the interview state, like next, etc. Review sections would be nice to test randomly, but they're less likely to crash the interview, and more likely to just have business logic errors, which would be harder to test.

@BryceStevenWilley BryceStevenWilley added the enhancement New feature or request label Dec 2, 2022
BryceStevenWilley added a commit that referenced this issue Dec 16, 2022
Reduces the chance a back button is pressed to max 10%.

Fixes #628.
BryceStevenWilley added a commit that referenced this issue Dec 16, 2022
Reduces the chance a back button is pressed to max 10%.

Fixes #628.
plocket pushed a commit that referenced this issue Aug 3, 2023
Reduces the chance a back button is pressed to max 10%.

Fixes #628.
plocket pushed a commit that referenced this issue Aug 4, 2023
Reduces the chance a back button is pressed to max 10%.

Fixes #628.
plocket pushed a commit that referenced this issue Oct 22, 2023
Reduces the chance a back button is pressed to max 10%.

Fixes #628.
plocket added a commit that referenced this issue Oct 24, 2023
* Fix errors in random tests

* Navigate back to the interview if you randomly leave

Happens with Exit buttons in kickout screens, which
randomly answer questions will get to often.

* Press the back button less often in random runs

Reduces the chance a back button is pressed to max 10%.

Fixes #628.

* Press other radio buttons than the last

Several bugs when pressing radio buttons:
* radio buttons were mistakenly found to be custom elements? Not sure why, but
  I did have to hard code an exception there.
* radio buttons were always being pressed, regardless of the actual desired
  answer

Still present, and not desirable: each radio button is considered separately,
heavily weighting the answers towards the latter radio buttons; the last button
has a 50% chance of being clicked, and the 2nd to last has a 25% chance, etc.

* Maybe avoid null error

* split type != radio logic from custom datatype

Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>

* Fix #629, artifact folders not being saved in GitHub

Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.

* Bump minor v to fix artifacts not being found

* Return default input type of 'text' when setting input see

comment at https://github.com/SuffolkLITLab/ALKiln/pull/633/files/a2db94dcc7e394497ec3c1b7d35a7f540126d0ff#r1134716311
See mdn docs at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#input_types

* Remove radio button changes (#806)

* Fix errors in random tests

* Bump minor v to fix artifacts not being found

* Remove radio button changes

---------

Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com>

---------

Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant