Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users' GitHub actions aren't creating any artifacts #629

Closed
plocket opened this issue Dec 4, 2022 · 1 comment · Fixed by #635
Closed

Users' GitHub actions aren't creating any artifacts #629

plocket opened this issue Dec 4, 2022 · 1 comment · Fixed by #635
Assignees
@plocket
Labels
bug Something isn't working

Comments

@plocket
Copy link
Collaborator

plocket commented Dec 4, 2022

A passing test and a failing test:

Warning: No files were found with the provided path: ./alkiln-*. No artifacts will be uploaded.

I think we recently changed names of things to shorten them for Windows systems. I think I reviewed that and must have missed it.

Edit:
Tracking this down, I actually think this was happening before the names were changed. What we need to do is publish the latest changes, which include what amounts to a fix for this. See the mismatching dash at https://github.com/SuffolkLITLab/ALKiln/pull/626/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6L46 and https://github.com/SuffolkLITLab/ALKiln/pull/626/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6L131.
@plocket
Copy link
Collaborator Author

plocket commented Dec 4, 2022 •
edited
Loading

The latest published version should have fixed this, but we need to test it. We need to change the folder name created in the running tests.

@plocket plocket added the bug Something isn't working label Dec 4, 2022
@plocket plocket self-assigned this Dec 29, 2022
plocket added a commit that referenced this issue Dec 29, 2022
@plocket
Fix #629, artifact folders not being saved in GitHub
9a23a4c 
Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.
@plocket plocket mentioned this issue Dec 29, 2022
Merged
BryceStevenWilley pushed a commit that referenced this issue Jan 3, 2023
@plocket @BryceStevenWilley
Fix #629, artifact folders not being saved in GitHub
a917e64 
Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.
plocket added a commit that referenced this issue Jan 9, 2023
@plocket
Fix #629, artifact folders not being saved in GitHub
7d3353e 
Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.
plocket added a commit that referenced this issue Jun 3, 2023
@plocket
Fix #629, artifact folders not being saved in GitHub
8ac4b1b 
Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.
plocket added a commit that referenced this issue Aug 3, 2023
@plocket
Fix #629, artifact folders not being saved in GitHub
7578a82 
Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.
plocket added a commit that referenced this issue Aug 4, 2023
@plocket
Fix #629, artifact folders not being saved in GitHub
d1e6e80 
Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.
plocket added a commit that referenced this issue Oct 22, 2023
@plocket
Fix #629, artifact folders not being saved in GitHub
304a0ac 
Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.
plocket added a commit that referenced this issue Oct 24, 2023
@BryceStevenWilley @plocket
Some random input fixes (#633)
e93c142 
* Fix errors in random tests

* Navigate back to the interview if you randomly leave

Happens with Exit buttons in kickout screens, which
randomly answer questions will get to often.

* Press the back button less often in random runs

Reduces the chance a back button is pressed to max 10%.

Fixes #628.

* Press other radio buttons than the last

Several bugs when pressing radio buttons:
* radio buttons were mistakenly found to be custom elements? Not sure why, but
  I did have to hard code an exception there.
* radio buttons were always being pressed, regardless of the actual desired
  answer

Still present, and not desirable: each radio button is considered separately,
heavily weighting the answers towards the latter radio buttons; the last button
has a 50% chance of being clicked, and the 2nd to last has a 25% chance, etc.

* Maybe avoid null error

* split type != radio logic from custom datatype

Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>

* Fix #629, artifact folders not being saved in GitHub

Also adjust internal test names to be a bit shorter and more
flexible in case we want to make them more modular in future. Not
as sure about that one.

* Bump minor v to fix artifacts not being found

* Return default input type of 'text' when setting input see

comment at https://github.com/SuffolkLITLab/ALKiln/pull/633/files/a2db94dcc7e394497ec3c1b7d35a7f540126d0ff#r1134716311
See mdn docs at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#input_types

* Remove radio button changes (#806)

* Fix errors in random tests

* Bump minor v to fix artifacts not being found

* Remove radio button changes

---------

Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com>

---------

Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plocket plocket

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #629, artifact folders not being saved in GitHub SuffolkLITLab/ALKiln
1 participant
@plocket