AL custom date fields aren't being filled in #764
Assignees
Labels
bug
Something isn't working
Comments
plocket
added a commit
that referenced
this issue
Sep 27, 2023
- Fix "today" not being converted into a date for custom datatypes. - Add new test for both. Also - Add new warning message to the developer when their date string doesn't have a `/` in it. - Use `Tab` keypress to un-focus from the current input field since that seems to have given us issues in the past (sorry about its inclusion here). - When downloading a file, changed the order of the check for a completed download. Sorry about this too. Ran into a weird error. I don't think this helps, but it is better code. Closes #764
3 tasks
plocket
added a commit
that referenced
this issue
Sep 29, 2023
* Add 3-part dates yml * Restore AL custom date functionality, fix "today"... - Fix "today" not being converted into a date for custom datatypes. - Add new test for both. Also - Add new warning message to the developer when their date string doesn't have a `/` in it. - Use `Tab` keypress to un-focus from the current input field since that seems to have given us issues in the past (sorry about its inclusion here). - When downloading a file, changed the order of the check for a completed download. Sorry about this too. Ran into a weird error. I don't think this helps, but it is better code. Closes #764 * Test b-day as day before yesterday to avoid server time issues
plocket
added a commit
that referenced
this issue
Oct 7, 2023
* Add 3-part dates yml * Restore AL custom date functionality, fix "today"... - Fix "today" not being converted into a date for custom datatypes. - Add new test for both. Also - Add new warning message to the developer when their date string doesn't have a `/` in it. - Use `Tab` keypress to un-focus from the current input field since that seems to have given us issues in the past (sorry about its inclusion here). - When downloading a file, changed the order of the check for a completed download. Sorry about this too. Ran into a weird error. I don't think this helps, but it is better code. Closes #764 * Test b-day as day before yesterday to avoid server time issues
plocket
added a commit
that referenced
this issue
Oct 7, 2023
* Add 3-part dates yml * Restore AL custom date functionality, fix "today"... - Fix "today" not being converted into a date for custom datatypes. - Add new test for both. Also - Add new warning message to the developer when their date string doesn't have a `/` in it. - Use `Tab` keypress to un-focus from the current input field since that seems to have given us issues in the past (sorry about its inclusion here). - When downloading a file, changed the order of the check for a completed download. Sorry about this too. Ran into a weird error. I don't think this helps, but it is better code. Closes #764 * Test b-day as day before yesterday to avoid server time issues
plocket
added a commit
that referenced
this issue
Oct 7, 2023
Closes #744 * Fail a11y and internal tests correctly * DA Accessibility upstream is fixed now * updating changelog and test * Bump version for case insensitive Step * told the user the interview url and closes #696 * Restore AL custom date functionality, fix "today"... (#766) * Add 3-part dates yml * Restore AL custom date functionality, fix "today"... - Fix "today" not being converted into a date for custom datatypes. - Add new test for both. Also - Add new warning message to the developer when their date string doesn't have a `/` in it. - Use `Tab` keypress to un-focus from the current input field since that seems to have given us issues in the past (sorry about its inclusion here). - When downloading a file, changed the order of the check for a completed download. Sorry about this too. Ran into a weird error. I don't think this helps, but it is better code. Closes #764 * Test b-day as day before yesterday to avoid server time issues * Bump for custom dates, "today", and clarified messages * Move report functions into their own file (#771) * Move report functions into their own file. Close #770 * Clean up function arguments, quotes, etc * Fail a11y and internal tests correctly * Clean up after rebase * Fix rebase typo --------- Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com> Co-authored-by: michaelhofrichter <45667758+michaelhofrichter@users.noreply.github.com> Co-authored-by: Joe Tran <joetran257@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We had to disable some tests recently for other reasons and it looks like we never updated our internal tests to isolate tests for AL custom dates separately.
What I believe is the source of the bug: There was recently a bug where interacting with a hidden (show if, I believe) date field blocked the field just below. We then started skipping hidden fields to avoid the bug. Unfortunately, the way we interact with the
ThreePartsDate/BirthDatefields is through their hidden field because of complications in trying to get it to otherwise submit the final value.We'll have to find another solution to one of those problems.
[We may have an additional problem on top of that one. Not sure what it is yet. Something's not being filled in.]
The text was updated successfully, but these errors were encountered: