Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor report functions into their own file #770

Closed
plocket opened this issue Oct 3, 2023 · 0 comments · Fixed by #771
Closed

Refactor report functions into their own file #770

plocket opened this issue Oct 3, 2023 · 0 comments · Fixed by #771
Assignees
@plocket
Labels
enhancement New feature or request

Comments

@plocket
Copy link
Collaborator

plocket commented Oct 3, 2023

No description provided.

@plocket plocket self-assigned this Oct 3, 2023
@plocket plocket added the enhancement New feature or request label Oct 3, 2023
@plocket plocket mentioned this issue Oct 4, 2023
Merged
3 tasks
plocket added a commit that referenced this issue Oct 4, 2023
@plocket
Move report functions into their own file (#771)
4cc468f 
* Move report functions into their own file. Close #770
* Clean up function arguments, quotes, etc
plocket added a commit that referenced this issue Oct 7, 2023
@plocket
Move report functions into their own file (#771)
891891d 
* Move report functions into their own file. Close #770
* Clean up function arguments, quotes, etc
plocket added a commit that referenced this issue Oct 7, 2023
@plocket
Move report functions into their own file (#771)
a5679dd 
* Move report functions into their own file. Close #770
* Clean up function arguments, quotes, etc
plocket added a commit that referenced this issue Oct 7, 2023
@plocket @BryceStevenWilley
@michaelhofrichter @jostran14
Fail a11y and internal tests correctly (#750)
527ea37 
Closes #744
* Fail a11y and internal tests correctly
* DA Accessibility upstream is fixed now
* updating changelog and test
* Bump version for case insensitive Step
* told the user the interview url and closes #696
* Restore AL custom date functionality, fix "today"... (#766)
* Add 3-part dates yml
* Restore AL custom date functionality, fix "today"...

- Fix "today" not being converted into a date for custom datatypes.
- Add new test for both.

Also

- Add new warning message to the developer when their date string doesn't have a `/` in it.
- Use `Tab` keypress to un-focus from the current input field since that seems to have given us issues in the past (sorry about its inclusion here).
- When downloading a file, changed the order of the check for a completed download. Sorry about this too. Ran into a weird error. I don't think this helps, but it is better code.

Closes #764

* Test b-day as day before yesterday to avoid server time issues

* Bump for custom dates, "today", and clarified messages

* Move report functions into their own file (#771)

* Move report functions into their own file. Close #770
* Clean up function arguments, quotes, etc

* Fail a11y and internal tests correctly

* Clean up after rebase

* Fix rebase typo

---------

Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com>
Co-authored-by: michaelhofrichter <45667758+michaelhofrichter@users.noreply.github.com>
Co-authored-by: Joe Tran <joetran257@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plocket plocket

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move report functions into their own file SuffolkLITLab/ALKiln
1 participant
@plocket