Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dainstall doesn't install dependencies anymore #827

Closed
plocket opened this issue Dec 5, 2023 · 6 comments · Fixed by #841
Closed

dainstall doesn't install dependencies anymore #827

plocket opened this issue Dec 5, 2023 · 6 comments · Fixed by #841
Assignees
Labels
bug Something isn't working

Comments

@plocket
Copy link
Collaborator

plocket commented Dec 5, 2023

docassemblecli changed dainstall a couple weeks ago and that's why our 3-parts dates tests are failing in the isolated GitHub server tests. The other AL tests are probably failing too. Maybe it's just getting buried in the noise.

Version 0.0.14 changes when it restarts the server. [I'm not sure what about it caused this issue, but changing my version of docassemblecli is what recreated the issue on my local server.] If there's no python file in the package being installed, it doesn't restart the server. It doesn't check for dependencies, so if there are dependencies, they don't get installed till the next restart/reload.


Old issue for posterity:

Topic: Running too fast?

Sometimes our tests fail because the ThreePartsDate custom fields aren't done adding themselves to the page (I think): the error says that the element is not a <select> element and the pic shows a regular text input field. I checked manually on the testing and dev server, and the fields look fine. [This is happening in our GitHub server tests, which might be running a faster server than we're used to.]

I'm reluctant to slow the tests down more, especially since these lag issues are so unpredictable and we're already waiting the for a bit over the length of animation on at least show if fields. Maybe we can just slow down tests for custom datatypes? Maybe we just add more info to the ThreePartsDate error message, but I'm not sure how much that would help.

@plocket plocket added question Further information is requested deep dive labels Dec 5, 2023
@plocket
Copy link
Collaborator Author

plocket commented Dec 14, 2023

Maybe we'll just slow down date steps... [at least for now] Didn't work because that wasn't the problem. Read above.

@plocket plocket self-assigned this Dec 14, 2023
@plocket plocket added bug Something isn't working and removed question Further information is requested deep dive labels Dec 17, 2023
@plocket plocket changed the title Running too fast? dainstall doesn't install dependencies anymore Dec 17, 2023
@BryceStevenWilley
Copy link
Collaborator

Version 0.0.14 changes when it restarts the server. [I'm not sure what about it caused this issue, but changing my version of docassemblecli is what recreated the issue on my local server.] If there's no python file in the package being installed, it doesn't restart the server. It doesn't check for dependencies, so if there are dependencies, they don't get installed till the next restart/reload.

That's fairly frustrating. IMO, that's an upstream bug; we don't know which dependencies would get installed from dainstall, so it should usually restart, or at least should let the server tell us if we should restart. Happy to help raise this issue upstream or try to fix it. Until then, we should pin to version 0.0.13 to avoid that behavior.

@plocket
Copy link
Collaborator Author

plocket commented Dec 19, 2023

Thank you. I'm debugging it and fixing it and should be able to make a PR soon. I like the idea of pinning the version in the future. For now, we do need other code in the new version, so we can't pin to 0.0.13 - it includes the code to ignore what's in the .gitignore. After this gets resolved, though, I'll look into pypi version-specific installation and we'll pin to the new working version 👍

@plocket
Copy link
Collaborator Author

plocket commented Dec 19, 2023

Should be resolved by jhpyle/docassemblecli#12 🤞

@plocket
Copy link
Collaborator Author

plocket commented Dec 19, 2023

Should I make a docassemblecli_alkiln python package just for us? A bit more control maybe, but I'm reluctant to have another package to maintain.

@plocket plocket added deep dive question Further information is requested labels Dec 19, 2023
@plocket
Copy link
Collaborator Author

plocket commented Dec 19, 2023

It's been merged, though not yet released. [Apparently needs some fixes first, sorry about that.]

plocket added a commit that referenced this issue Dec 21, 2023
Use custom docassemblecli repo (rejected)
Use custom docassemblecli in the old action as well (rejected)
Try new version of docassemblecli
Use pip instead of pip3
Close #827 Freeze docassemblecli version at 0.0.17
@plocket plocket removed question Further information is requested deep dive labels Dec 21, 2023
plocket added a commit that referenced this issue Dec 21, 2023
Use custom docassemblecli repo (rejected)
Use custom docassemblecli in the old action as well (rejected)
Try new version of docassemblecli
Use pip instead of pip3
Close #827 Freeze docassemblecli version at 0.0.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants