-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dainstall doesn't install dependencies anymore #827
Comments
|
That's fairly frustrating. IMO, that's an upstream bug; we don't know which dependencies would get installed from |
Thank you. I'm debugging it and fixing it and should be able to make a PR soon. I like the idea of pinning the version in the future. For now, we do need other code in the new version, so we can't pin to |
Should be resolved by jhpyle/docassemblecli#12 🤞 |
Should I make a |
It's been merged, though not yet released. [Apparently needs some fixes first, sorry about that.] |
Use custom docassemblecli repo (rejected) Use custom docassemblecli in the old action as well (rejected) Try new version of docassemblecli Use pip instead of pip3 Close #827 Freeze docassemblecli version at 0.0.17
docassemblecli changed dainstall a couple weeks ago and that's why our 3-parts dates tests are failing in the isolated GitHub server tests. The other AL tests are probably failing too. Maybe it's just getting buried in the noise.
Version 0.0.14 changes when it restarts the server. [I'm not sure what about it caused this issue, but changing my version of docassemblecli is what recreated the issue on my local server.] If there's no python file in the package being installed, it doesn't restart the server. It doesn't check for dependencies, so if there are dependencies, they don't get installed till the next restart/reload.
Old issue for posterity:
Topic: Running too fast?
Sometimes our tests fail because the ThreePartsDate custom fields aren't done adding themselves to the page (I think): the error says that the element is not a
<select>
element and the pic shows a regular text input field. I checked manually on the testing and dev server, and the fields look fine. [This is happening in our GitHub server tests, which might be running a faster server than we're used to.]I'm reluctant to slow the tests down more, especially since these lag issues are so unpredictable and we're already waiting the for a bit over the length of animation on at least
show if
fields. Maybe we can just slow down tests for custom datatypes? Maybe we just add more info to the ThreePartsDate error message, but I'm not sure how much that would help.The text was updated successfully, but these errors were encountered: