Close #827 Freeze docassemblecli version at 0.0.17 #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use custom docassemblecli repo (rejected) Use custom docassemblecli in the old action as well (rejected) Try new version of docassemblecli Use pip instead of pip3 Close #827 Freeze docassemblecli version at 0.0.17
| @@ -31,6 +31,10 @@ inputs: | |||
| ALKILN_TAG_EXPRESSION: | |||
| description: "The tag expression to use to limit which tests to run. Default is no tag expression." | |||
| required: false | |||
| DOCASSEMBLECLI_VERSION: | |||
| description: 'Where to get the docassemblecli package. E.g. a GitHub zip or a pypi version.' | |||
There was a problem hiding this comment.
Fairly certain this syntax pip install docassemblecli==$DOCASSEMBLCLI_VERSION will only work with specific pypi versions. You'd to wrap the whole thing in quotes for it to work with @ https://github.com/.../archive/main.zip. https://pip.pypa.io/en/stable/reference/requirement-specifiers/ should have the different things pip accepts.
To be clear, I think restricting to pypi versions of the package is fine, but I just think that should be reflected in the description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use custom docassemblecli repo (rejected)
Use custom docassemblecli in the old action as well (rejected) Try new version of docassemblecli
Use pip instead of pip3
Close #827 Freeze docassemblecli version at 0.0.17
In this PR, I have:
Added tests for any new features or bug fixes (if relevant)Reason for this PR
docassemblecli wasn't installing dependencies on the given server. It got fixed upstream and we're freezing at this version to have better control over what changes we pull in.
Links to any solved or related issues
Closes #827
Any manual testing I have done to ensure my PR is working
Tested
dainstalllocally, but most of the testing was in GitHub as it is the environment we're concerned about.