Challenges 1-3 Are Passing Test #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
johnny-rice,
itsdanielguerrero,
orbitalbitmap and
sashgems
johnny-rice
reviewed
Jul 14, 2020
| @@ -13,11 +13,24 @@ | |||
| @Test - Write a console.log that shows the value of `increaseLevel(10)` | |||
| */ | |||
|
|
|||
| function increaseLevel(valuePassed) { | |||
| valuePassed++ | |||
There was a problem hiding this comment.
Nice work on the shorthand syntax.
johnny-rice
reviewed
Jul 14, 2020
| /* | ||
| @Challenge 02 - Write a function named `makeEchoes` that loops for the number of times indicated and console.log's "Echo!" in each loop | ||
| @Example - Sending the function a value of 5 will result in 5 "Echo!"'s in the terminal | ||
| @Test - Make a function call of `makeEchoes(5)` | ||
| */ | ||
| function makeEchoes (x) { |
There was a problem hiding this comment.
Good work. Consider avoiding single letter variables in favor or more meaningful names.
johnny-rice
reviewed
Jul 14, 2020
| /* | ||
| @Challenge 04 - Write a function named `showTheFifties` that loops from 1 to 200. | ||
| Use a condition in the loop to console.log the number when it is over 49 and under 60 | ||
| @Example - Expect to see 50, 51, 52, 53, 54, 55, 56, 57, 58, 59 in the terminal | ||
| @Test - Make a function call of `showTheFifties()` | ||
| */ | ||
| function showTheFifties(x) { | ||
| let i; |
There was a problem hiding this comment.
Extra let statement here on 61. Not harmful. Not needed though so making note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.