Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TF support for configuring Data Forwarding Rules #688

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

namangoya
Copy link
Collaborator

@namangoya namangoya commented Sep 18, 2024

Added TF support for data forwarding /rules.

Slack Conversation - link

  • The tests are failing because of this issue, hence I am not adding the test as a part of this PR. I have locally ran the tests and they are passing, so we will add those tests right after the above issue is fixed.

Documentation

Please review commit by commit

Attaching the screenshots of passing tests in my local. (Rule is getting created and then updated)

Screenshot 2024-09-19 at 5 05 52 PM Screenshot 2024-09-19 at 5 06 08 PM

@namangoya namangoya marked this pull request as ready for review September 18, 2024 18:44
@namangoya namangoya requested a review from dagould as a code owner September 18, 2024 18:44
@namangoya namangoya force-pushed the adding_TF_support_for_DF_rules branch from 5f0a9aa to 38ba25a Compare September 19, 2024 12:44
Copy link
Collaborator

@ssharma-sumologic ssharma-sumologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, rest lgtm

@namangoya
Copy link
Collaborator Author

namangoya commented Sep 19, 2024

I've tested the changes manually also and everything is working fine, attaching the main.txt (rename it to main.tf) and test results.

Steps to test

  • Rename the main.txt file to main.tf
  • Copy the main.tf in /terraform-provider-sumologic directory (i.e. in the repo itself), and populate the variables
  • Run make install-dev
  • Run terraform init
  • Run terraform plan
  • Run terraform apply

Flow of the tests is

Creating resources
  • Run terraform plan and verify the plan and then run terraform apply
  • Creating a partition.
  • Creating a data forwarding destination.
  • Configuring the data forwarding rule on the above partition.
Deleting resources
  • Comment out the resource and run terraform apply, it will delete all the 3 resources it created above

Creation 1
Creation 2
Deletion

@namangoya namangoya merged commit d0b898b into master Sep 19, 2024
7 checks passed
@namangoya namangoya deleted the adding_TF_support_for_DF_rules branch September 19, 2024 17:19
@namangoya namangoya mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants