-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TF support for configuring Data Forwarding Rules #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t on the SUMOLOGIC_TEST_BUCKET_NAME bucket
namangoya
force-pushed
the
adding_TF_support_for_DF_rules
branch
from
September 19, 2024 12:44
5f0a9aa
to
38ba25a
Compare
ssharma-sumologic
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, rest lgtm
…tency with the API, and added omitempty in the model
I've tested the changes manually also and everything is working fine, attaching the main.txt (rename it to Steps to test
Flow of the tests isCreating resources
Deleting resources
|
sjain05
approved these changes
Sep 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TF support for data forwarding /rules.
Slack Conversation - link
Documentation
Please review commit by commit
Attaching the screenshots of passing tests in my local. (Rule is getting created and then updated)