Add tracing of resolve, for troubleshooting #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lving issues in production
|
jstarpl
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Code improvement.
This PR replaces the debug-tracing to console.log, with logging to
resolvedTimeline.statistics.resolveTrace.It also changes a thrown
Errorinto aResolveErrorthat contains the (partially resolved)resolvedTimeline.This allows for a consumer of the Timeline resolver to try/catch and better log the
resolveTrace, to figure out what might have gone wrong.(This is an attempt to fix a
"Internal Error: There is already an object on layer"issue in production, see TSR PR.)