Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace timeline errors #351

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Trace timeline errors #351

merged 3 commits into from
Oct 10, 2024

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Oct 3, 2024

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Code improvement

New Behavior

This PR adds try/catch handling around the timeline resolver calls, and traces helpful additional information in case of thrown errors.

Other Information

(This is an attempt to fix a Timeline "Internal Error: There is already an object on layer" issue.)

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin requested a review from a team as a code owner October 3, 2024 11:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 13.79310% with 25 lines in your changes missing coverage. Please review.

Project coverage is 51.74%. Comparing base (72e9fb6) to head (5962b48).
Report is 1 commits behind head on release51.

Files with missing lines Patch % Lines
...kages/timeline-state-resolver/src/AsyncResolver.ts 0.00% 20 Missing and 2 partials ⚠️
packages/timeline-state-resolver/src/conductor.ts 57.14% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release51     #351      +/-   ##
=============================================
- Coverage      51.84%   51.74%   -0.10%     
=============================================
  Files            127      127              
  Lines          10183    10204      +21     
  Branches        2470     2537      +67     
=============================================
+ Hits            5279     5280       +1     
- Misses          4480     4498      +18     
- Partials         424      426       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin merged commit 2b45bc8 into release51 Oct 10, 2024
36 checks passed
@nytamin nytamin deleted the chore/trace-timeline-errors branch October 10, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants