Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

HTML pin adapter 🎉 #522

Merged
merged 87 commits into from
Jan 19, 2024
Merged

HTML pin adapter 🎉 #522

merged 87 commits into from
Jan 19, 2024

Conversation

carlossantos74
Copy link
Collaborator

No description provided.

Raspincel added 30 commits January 3, 2024 08:08
@Raspincel
feat: create wrappers over elements with data-superviz-id
a0c37b4
@Raspincel
feat: watch data-attribute changes with mutation observer
31259be
@Raspincel
feat: add temporary pin when clicking on element
8476676
@Raspincel
feat: add pin to element
579ea56
@Raspincel
feat: remove temporary pin when pressing Escape
6eb16f0
@Raspincel
feat: focus on pin when creating on clicking on pin/annotation
c40ab04
@Raspincel
feat: display or hide pins according to changes in data-superviz-id
7a546da
@Raspincel
feat: adapt wrapper size to element size
bfe9c15
@Raspincel
fix: append temporary pin to wrapper instead of element
14967e0
@Raspincel
fix: render temporary pin in other wrapper so input that overflows is…
8203a5a 
… not hidden
@Raspincel
refactor: reestructure, comment and organize code
6fb0f10
@Raspincel
fix: position pin exactly at mouse pointer
5d3319f
@Raspincel
fix: remove pin from element if element loses data-attribute
d472687
@Raspincel
fix: toggle sidebar if clicking on pin when sidebar is closed
a4c4cc9
@Raspincel
fix: stop observing resize only if element loses data-superviz-id att…
a4222c4 
…ribute
@Raspincel
feat: create public method to translate the pins over an element
a6e11e3
@Raspincel
feat: append all wrappers to a single div inside the specified container
8d06252
@Raspincel
feat: create tests for html-pin-adapter
29aa1c6
@Raspincel
feat: add new type to html pin adapter
8ab06ef
@Raspincel
feat: create public method to scale and translate the entire pins con…
ca7208e 
…tainer
@Raspincel
feat: update pins positions on scroll
8365d11
@Raspincel
fix: stop showing comments over delete modal
3513baf
@Raspincel
feat: create test for onScroll callback
d6b5922
@Raspincel
fix: remove pin from element even if element does not have the specif…
2ed4924 
…ied data-attribute
@Raspincel
fix: toggle annotation active attribute when clicking on it multiple …
27b66af 
…times
@Raspincel
feat: set high z-indexes to comments button and sidebar and to modals
adeea4c
@Raspincel
feat: set z-index to pins container
9e22f30
@Raspincel
fix: set selectPin to null when removing data-attribute
56d86cd
@Raspincel
fix: pass options to html pin constructor inside an object
853a4aa
@Raspincel
fix: set to undefined instead of using keyword delete
456f103
carlossantos74 and others added 25 commits January 15, 2024 14:36
@carlossantos74
feat: notify main channel when the participant data is updated
18e04e1
@Raspincel
feat(HTMLPin): hide temporary pin if clicking anywhere else on the sc…
b08995f 
…reen
@carlossantos74
ci: add beta and lab release channels on npm
ac61e72
@carlossantos74
ci(checks): when run checkes delete previus superviz-dev comments
a048eb9
@Raspincel
feat: emit flag to not call go to pin when creating annotation
2abd39b
@Raspincel
fix(CanvasPin): do not go to pin when creating annotation
6cdac50
@Raspincel
feat: hide temporary pin if clicking anywhere else on the screen
548a087
@Raspincel
fix: correct tests
4321871
@carlossantos74
Merge pull request #505 from SuperViz/feat/hide-temp-pin-click
17b9274 
feat: hide temp pin click
@carlossantos74
Merge pull request #504 from SuperViz/ci/add-beta-and-lab-package
c7ba576 
ci: add beta and lab channels
@carlossantos74
feat: ensure that only one room is open per browser
8385977
@Raspincel
fix: limit how much participants dropdown can grow and add scrollbar …
02626ba 
…instead
@carlossantos74
Merge pull request #506 from SuperViz/ci/add-beta-and-lab-package
059a98e 
feat: ensure that only one room is open per browser
@carlossantos74
Merge pull request #507 from SuperViz/fix/limit-max-size-dropdown
1c7f36d 
fix: limit how much participants dropdown can grow and add scrollbar instead
@Raspincel
fix: only hide temporary pin if current wrapper was not clicked
f9a48dd
@Raspincel
feat(HTMLPin): support rect and ellipse svg elements
78dfa1c
@Raspincel
fix: remove unecessary scroll
9bf2772
@carlossantos74
fix: remove same account check from core
592ad36
@carlossantos74
Merge pull request #513 from SuperViz/fix/same-account-error
bd0e7d7 
fix: remove same account check from core
@Raspincel
fix: correct tests
6e9151d
@carlossantos74
Merge pull request #512 from SuperViz/feat/html-pin-svg-support
1a8010b 
feat: html pin svg support
@Raspincel
fix: position pin correctly on scroll
a56b5cf
@Raspincel
fix: remove colors
2f171c5
@carlossantos74
Merge pull request #516 from SuperViz/fix/html-pin-svg-scroll
8678434 
fix: position pin correctly on scroll
@carlossantos74
Merge pull request #508 from SuperViz/lab
61f2310 
HTML Pin Adapter 🎉
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 90.14%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   colors.types.ts 100% 100% 100%
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 87.50% 20
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observable.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 85.71% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 92.59% 97.14% 98.51% 139, 198, 451, 548, 564
   types.ts 100% 100% 100%
src/components/comments/canvas-pin-adapter
   index.ts 64.71% 88.89% 90.18% 196, 197, 198, 247, 247, 247, 247, 248, 249, 252, 252, 253, 256, 322, 323, 325, 325, 325, 327, 327, 328, 330, 331, 334, 336, 400, 413, 417, 430, 451, 476, 496, 497, 508, 510, 510, 510, 510, 512, 513
src/components/comments/html-pin-adapter
   index.ts 88.57% 98.15% 83.62% 269, 270, 271, 476, 477, 479, 479, 481, 482, 484, 484, 484, 484, 486, 487, 580, 581, 581, 582, 583, 584, 585, 586, 587, 588, 590, 593, 594, 595, 597, 597, 597, 597, 599, 600, 609, 609, 610, 611, 612, 613, 614, 615, 616, 617, 618, 619, 620, 621, 622, 625, 625, 626, 627, 629, 630, 631, 632, 633, 634, 636, 637, 638, 639, 640, 641, 644, 645, 647, 648, 650, 652, 654, 655, 656, 759, 760, 761
src/components/presence-mouse
   index.ts 80.65% 100% 100% 206, 206, 206, 206, 276, 286
src/components/realtime
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/components/video
   index.ts 97.06% 100% 100% 197
src/components/who-is-online
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/core
   index.ts 90.91% 80% 84.09% 100, 103, 107, 108, 110, 123, 129, 79, 80
src/core/launcher
   index.ts 94.12% 100% 100% 256
src/services
src/services/api
   index.ts 100% 86.67% 86.54% 100, 101, 103, 109, 110, 111, 112
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/limits
   index.ts 75% 100% 100% 10
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 90% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 54.91% 62.28% 70.52% 1018, 1019, 102, 1059, 106, 1060, 1071, 1075, 1079, 110, 1115, 1174, 118, 1183, 1185, 1185, 1186, 122, 123, 1284, 1288, 1289, 1290, 1324, 1325, 1329, 1335, 1335, 1336, 1339, 1341, 1342, 1343, 1346, 1350, 1350, 1352, 1353, 1357, 1357, 1357, 1359, 1363, 1365, 1371, 1375, 1376, 1386, 1388, 1394, 1411, 1411, 1413, 1414, 1415, 1446, 1446, 1447, 1452, 1453, 1456, 1459, 1459, 1460, 1461, 1463, 1464, 1465, 1468, 1472, 1472, 1474, 1475, 1479, 1479, 1479, 1479, 1481, 1481, 1481, 1483, 1491, 1491, 1493, 1497, 1497, 1498, 1501, 1503, 1515, 1516, 1526, 1528, 1538, 1540, 1540, 1541, 1544, 196, 220, 286, 427, 429, 430, 440, 453, 466, 466, 468, 480, 481, 482, 515, 525, 526, 547, 548, 550, 551, 553, 553, 554, 568, 570, 573, 575, 585, 586, 587, 588, 589, 589, 590, 591, 603, 605, 615, 617, 619, 621, 622, 622, 628, 628, 628, 628, 628, 629, 631, 633, 636, 636, 636, 636, 636, 637, 639, 640, 640, 640, 640, 640, 641, 642, 642, 642, 642, 642, 643, 644, 644, 645, 645, 645, 645, 650, 652, 655, 657, 657, 657, 657, 658, 660, 677, 678, 688, 689, 699, 741, 742, 771, 773, 774, 775, 775, 776, 779, 786, 786, 787, 787, 789, 789, 789, 792, 793, 796, 796, 797, 798, 801, 802, 804, 809, 909, 909, 910, 913, 915, 915, 915, 916, 918, 972, 974, 975, 977, 979, 981, 981, 981, 981, 982, 983, 984, 987, 988, 991, 994, 994, 994, 994, 995
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 64.10% 86.11% 93.62% 117, 120, 121, 122, 163, 168, 200, 201, 206, 207, 208, 211, 211, 212, 214, 215, 292, 327, 328, 329, 382, 416, 527, 539, 582, 586
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 98.54%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 80.52% 29, 30, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 92.86% 87.50% 98.26% 45, 46, 62
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 96.64% 154, 155, 156, 157, 158, 159, 160, 161
   annotation-pin.ts 100% 100% 94.24% 104, 109, 110, 111, 112, 163, 164, 165, 228, 62, 63, 64, 65, 66
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 100% 99.12% 93, 94
   comment-item.ts 100% 100% 100%
   content.ts 96.15% 81.82% 88.71% 104, 105, 35, 36, 39, 40, 41, 47, 48, 49, 63, 74, 75, 76, 77
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 96.15% 41, 61, 62
   index.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   watermark.ts 100% 100% 90.77% 17, 18, 19, 20, 21, 22
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 97.74% 100% 99.59% 264, 410, 443, 73, 76
   types.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 96.77% 100% 100% 79
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 97.12% 100% 99.47% 327, 327, 327, 328, 329
src/web-components/who-is-online/components
   dropdown.ts 94.94% 95.65% 98.97% 138, 139, 171, 171, 183, 183, 184, 185
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@carlossantos74 carlossantos74 merged commit d09ad1d into main Jan 19, 2024
6 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossantos74 @SuperViz-Dev @Raspincel @afonsovinicius