Fixed Typos in Voting template #243 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Having Templates in zip form is not a viable option as the the source code is not viewable and can not be reviewed or tested. |
|
@futurejones Your comment was replied on: #260 (comment). Thanks! |
filippsen
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
- Line 111 and 148 - Typo on Successfully. OK
- Line 115 - Typo on Editing. OK
Editing the file resulted in compressed output for the edited part (app.js), which turned the file smaller in size. The "safest" approach would have been to use Lab itself to generate the updated project file by using the Download project action (accessed from the projects list in the top bar). There is apparently no problem doing the way it was done, though (be it with Vim or any archiver tool).
Resolves #243. OK!
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixed 3 typos found in issue Typos in Voting template #243
superblocks-lab/src/templates/voting.zip
Alternate Designs
Benefits
Possible Drawbacks
Verification Process
Modified directly from the zip file and then saved. Checked if changes where saved and then commit & pushed.
Github Issues