-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare UI for iframe embed and other several minor fixes #300
Conversation
…en scrolled too far
…l is opened (1300px device and below)
…-lab into responsive-upgrade # Conflicts: # src/components/projecteditor/panes.js # yarn.lock
It appears that commit a41e276 touches the voting template and replaces the fixes applied in #258. Please double check. edit: there are also changes to |
…oast message for iframe
…-lab into responsive-upgrade # Conflicts: # src/components/bottomBar/BottomBar.js # src/components/networkAccountSelector/index.js # src/components/networkAccountSelector/style.less # src/components/projecteditor/control/control.js # src/components/projecteditor/style.less # src/components/topbar/Topbar.js
Edited the request description to update information about items that are already applied to ps: added a new item about moving |
…), update note proptypes
…-lab into responsive-upgrade # Conflicts: # src/components/projecteditor/style.less # src/components/topbar/Topbar.js
@Spejbl I have a few questions and considerations:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist
Initial
- Test regular development build works (localhost). No errors or apparent abnormalities. OK
- Experiment with other randomly selected smaller screen dimensions. OK
- Verify iframe size accounted for 960x500 pixels (Chrome Dev Tools in Responsive mode). OK (details mentioned in previous comments).
- Test iframe-lab.html works. OK
- Test iframe-lab.html matches attached screenshot. OK
Listed items
- Fix tab name splitting into 2 lines (also in panel's titles). OK
- Fix right click dropdown position when clicking on tab. OK
- Fix account, project name and hashes overflow when too long. OK
- Fix Preferences modal on smaller device (overflowing).
Modal is always centered and just fits 960x500 dimensions. Resolutions below that offer scrolling bars to navigate. OK - Fix mainWrapper (all panels and main "code" window) overlaying bottomBar.
Bottom bar is always visible, OK - Display open tabs in one line. OK
- Move Learning & Resources to Help menu on smaller device when a project is open. OK
- Add Open in Lab button when in iframe.
Opens Lab in a new tab loading existing project from hash. OK - Disable right click on Learning & Resources. OK
- Remove title of project on iframe.
The projects menu button together with the title are not present anymore. OK - Make bottomBar to stretch full width.
Bottom bar uses all the available width. OK - Hide unnecessary info on welcome screen on smaller device/iframe. OK
- Hide Analytics modal on iframe. Unable to see the Analytics modal during tests. OK
- Hide yellow note in bottomBar on iframe. OK
- Hide upload & fork button on iframe. OK
Related issues
- Fixes issues reported in Improve responsiveness so it works on smaller devices #255. OK
- Fixes issues reported in OverFlow hashes of Transaction History while decreasing size #188. OK
Code
No relevant oddities spotted in this code changeset. OK
Description of the Change
Changes - iframe size accounted for: 960x500px
Fix tab name splitting into 2 lines (also in panel's titles)
Fix right click dropdown position when clicking on tab
Fix account, project name and hashes overflow when too long
Fix Preferences modal on smaller device (overflowing)
Fix mainWrapper (all panels and main "code" window) overlaying bottomBar
Display open tabs in one line
Move Learning & Resources to Help menu on smaller device when a project is open
Add Open in Lab button when in iframe
Disable right click on Learning & Resources
Remove title of project on iframe
Make bottomBar to stretch full width
Hide unnecessary info on welcome screen on smaller device/iframe
Hide Analytics modal on iframe
Hide yellow note in bottomBar on iframe
Hide upload & fork button on iframe
Benefits
Better UX for users with smaller device and when Lab is embedded into iframe.
Verification Process
Github Issues
Resolves #255 #188