Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed grammar and changed some jokes from single to twopart #130

Closed
wants to merge 3 commits into from
Closed

Fixed grammar and changed some jokes from single to twopart #130

wants to merge 3 commits into from

Conversation

ThatCopy
Copy link
Contributor

Fixed grammar and changed some jokes from single to twopart. I allowed edits so you can change some jokes back.

@Sv443
Copy link
Member

Sv443 commented Jul 15, 2020

Thanks for the PR, but a twopart joke needs some kind of cliffhanger-y kind of vibe in the setup so that people want to know the delivery (if that makes sense), which a lot of your edits don't have.

@Sv443 Sv443 self-assigned this Jul 15, 2020
@Sv443 Sv443 added this to the 2.2.0 milestone Jul 15, 2020
@Sv443 Sv443 mentioned this pull request Jul 15, 2020
Merged
@Sv443
Copy link
Member

Sv443 commented Jul 15, 2020

@ThatCopy I've recreated it in #131, please tell me if you're fine with it.

@Sv443 Sv443 closed this Jul 15, 2020
@snyk-bot snyk-bot mentioned this pull request Dec 14, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2021
Open
@usernamerandom11 usernamerandom11 mentioned this pull request May 23, 2022
Open
@usernamerandom11 usernamerandom11 mentioned this pull request Aug 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Sv443 Sv443

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ThatCopy @Sv443