Fix static checking support (jshint, coffeelint, tslint) #279
Conversation
| <% if (props.jsPreprocessor.extension === 'js') { %> | ||
| .pipe($.jshint()) | ||
| .pipe($.jshint.reporter('jshint-stylish')) | ||
| <% } if (props.jsPreprocessor.key !== 'none') { %> |
There was a problem hiding this comment.
I remove this line because it's dead code, as gulp/script.js won't be included if props.jsPreprocessor.key === 'none'.
Toilal
force-pushed
the
feat/static
branch
4 times, most recently
from
559062f to
c2ff5f9
Compare
|
I don't like adding a new gulp script. We could use the |
|
So i remove https://github.com/Swiip/generator-gulp-angular/blob/master/app/src/format.js#L203-L205 for script to be included when no js preprocessor ? |
|
And what about |
|
@Swiip please tell me your thinkings about the current implementation. I've added a global |
|
Ping :) |
|
Ping @Toilal |
|
Sorry for delay, i'm on it. |
|
I've rebased locally, but |
|
|
|
Ok, i needed to remove old temporary directories from |
Toilal
force-pushed
the
feat/static
branch
3 times, most recently
from
c4f4d49 to
9cbeff7
Compare
|
Ready to merge I think. Note that |
| errorHandler: function(title) { | ||
| failOnLintErrors: true, | ||
| failOnCompileErrors: true, | ||
| errorHandler: function(title, throw_) { |
There was a problem hiding this comment.
Why throw_ ? strange name for a variable
There was a problem hiding this comment.
throw is a reserved keyword
Le 20 févr. 2015 11:33, "Mehdy Dara" notifications@github.com a écrit :
In app/templates/_gulpfile.js
#279 (comment)
:@@ -10,10 +10,16 @@ var options = {
dist: '<%= props.paths.dist %>',
tmp: '<%= props.paths.tmp %>',
e2e: '<%= props.paths.e2e %>',
- errorHandler: function(title) {
- failOnLintErrors: true,
- failOnCompileErrors: true,
- errorHandler: function(title, throw_) {
Why throw_ ? strange name for a variable
—
Reply to this email directly or view it on GitHub
https://github.com/Swiip/generator-gulp-angular/pull/279/files#r25061614
.
There was a problem hiding this comment.
yeah throw is reserved. rename throw_ to error
|
Any idea why it fails on iojs ? |
|
Maybe conflict with node-sass I restart build |
|
Can you rebase your branch with master ? We fix travis by ignore fail on iojs. |
Toilal
force-pushed
the
feat/static
branch
2 times, most recently
from
aa0783c to
1922a8b
Compare
|
I've just rebased this one, could you merge ? |
This close #277, but also moves all jshint/coffeelint/tslint to a static.js gulp file, support two tasks :
staticandstatic:fail.staticonly displays warning, butstatic:failalso raise an error.Those tasks are registered in
gulp build(static:fail) andgulp watch(static).