Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lintering #396

Merged
merged 5 commits into from
Mar 4, 2015
Merged

Fix lintering #396

merged 5 commits into from
Mar 4, 2015

Conversation

zckrs
Copy link
Collaborator

@zckrs zckrs commented Mar 4, 2015

The workflow should run linter for task gulp build gulp test gulp protractor gulp serve and when watching files (add, edit, delete)

  • Javascript (:heavy_check_mark: build :heavy_check_mark: test :heavy_check_mark: protractor :heavy_check_mark: serve :heavy_check_mark: watch)
  • Coffeescript (:heavy_check_mark: build :heavy_check_mark: test :heavy_check_mark: protractor :heavy_check_mark: serve :heavy_check_mark: watch)
  • Traceur (:heavy_check_mark: build :heavy_check_mark: test :heavy_check_mark: protractor :heavy_check_mark: serve :heavy_check_mark: watch)
  • Babel (:x: build :x: test :x: protractor :x: serve :x: watch)
  • Typescript (:heavy_check_mark: build :heavy_check_mark: test :heavy_check_mark: protractor :heavy_check_mark: serve :heavy_check_mark: watch)

close #326 close #277 close #279

@Swiip
Copy link
Owner

Swiip commented Mar 4, 2015

👍

About babel. As we use only browserify it's complicated. At the end, we should use both gulp scripts and a browserify task like traceur. But as I planned to replace Browserify by Webpack, you can leave it like that for now.

Swiip added a commit that referenced this pull request Mar 4, 2015
@Swiip Swiip merged commit ae48c9e into Swiip:master Mar 4, 2015
@Swiip
Copy link
Owner

Swiip commented Mar 4, 2015

need it to look at a PR for webpack :p

@williamboman
Copy link

I cannot find a jshint task anywhere after scaffolding with vanilla js.

@Swiip
Copy link
Owner

Swiip commented Mar 10, 2015

Not released yet, sorry. Should be soon (0.10)

@zckrs zckrs deleted the fix-linter branch September 9, 2015 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jshint is not running jshint check is not performed
3 participants