fix: Using IO.delay to defer evaluating the logging call #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `pure` the effect is evaluated exactly once when creating the IO, but not when evaluating it.
jachro
approved these changes
Sep 15, 2022
Merged
jachro
added a commit
that referenced
this pull request
Sep 22, 2022
* fix: adding --skip-template-update to renku migrate * feat: Adding `visibility` to dataset detail response (#1092) * refactor: Better GitLab stub (#1088) * fix: Using IO.delay to defer evaluating the logging call (#1089) * refactor: add generic JSON encoder for all TinyTypes (#1087) * chore: KG processes documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
purethe effect is evaluated exactly once when creating the IO, but not when evaluating it.