-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare 2.19.0 #1095
Merged
Merged
chore: prepare 2.19.0 #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: use GitLab Client in more places
* feat: global commit sync is triggered after a change occurred during the commit sync
* fix: Authorizer to allow authenticated users with no explicit rights * fix: free-text DS search to return internal DSs for authenticated user * fix: lineage to return internal project entities for authenticated user
* test: added test for re-provisioning process
…#886) * fix: added retry mechanism when storing and fetching the access token
* feat: GET /entities to read multi-valued namespace query param * feat: renku:projectNamespace added to the ontology * feat: TS migration to add missing renku:projectNamespace
When using `pure` the effect is evaluated exactly once when creating the IO, but not when evaluating it.
* feat: Starting with a GitLab stub based on http4s This commit only introduces the concept and migrates one test for demonstration purposes. * feat: Migrating `ProjectsResourcesSpec` * refactor: Improve usage and design of GitLabApiStub syntax More "low-level" operations are collected as functions in `GitLabStateUpdates` and `GitLabStateQueries`, respectively. Convenience syntax for writing tests are based on those and provided in `GitLabStubIoSyntax`. * feat: Migrate more tests to new GitLabStub * feat: Fix adding commits, migrate CommitHistoryChangesSpec * feat: Migrating CommitSyncFlowsSpec * feat: Migrate EventFlowsSpec * feat: Migrate EventsProcessingStatusSpec * feat: Migrate FastTractEventRouteSpec * chore: Add missing license headers * feat: Migrate remaining specs * chore: Deactivate previous GitLabStub * refactor: More robust startup * Fix EventsResourceSpec * refactor: test trait GitLabStubSupport inherits the syntax * refactor: remove now obsolete code * refactor: pass the accessToken explicitely Sometimes there has to be differentiated between different users * refactor: Renamings - AcceptanceSpec is now the base for all tests (was BaseSpec) - rename GraphServices -> ApplicationServices - pulled out DatasetsEncoders * fix: Try fixing generators in tests The generators used some random implicit value imported via `.testentities._` or `EntitiesGenerators._`. But it requires to use the same urls as used by the backend services. The gitlab-url must be used from the config file in the acceptance tests. * Refactor: move `findAllpersons` into `RenkuProject` companion
eikek
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visibility
to dataset detail response (feat: Addingvisibility
to dataset detail response #1092)