Skip to content

Commit

Permalink
Finish the switch to rubyzip
Browse files Browse the repository at this point in the history
We switched from `zipruby` to `rubyzip` in 2018
(commit d65d5a3)

However, we forgot to change the `gemspec` in the proces (oopsie), so
apps that use this gem are still installing `zipruby`, which hasn't been
touched in 10 years, and doesn't compile today without magic compiler
flags.

This finishes that upgrade.

I chose version `1.3.0` because our main app happens to be using another
gem which requires `rubyzip`, and it specifies `< 2.0.0`, and I want to
limit the rabbit hole i'm digging for myself here. But ideally we'd move
this to the latest version.
  • Loading branch information
dmagliola committed May 13, 2021
1 parent e6f28f8 commit 644a77c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spreadsheetx.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Gem::Specification.new do |s|
s.specification_version = 3

s.add_runtime_dependency('libxml-ruby', ['~> 3.1.0'])
s.add_runtime_dependency('zipruby', ['~> 0.3.6'])
s.add_runtime_dependency('rubyzip', ['~> 1.3.0'])
s.add_development_dependency('bundler', ['~> 1.0.0'])
s.add_development_dependency('jeweler', ['~> 1.6.2'])
s.add_development_dependency('rcov', ['>= 0'])
Expand Down

0 comments on commit 644a77c

Please sign in to comment.