command prompt in docker

[KrisThielemans]

Oh, one other point, the terminal from Jupyter has a horrible command prompt that appears after every command:

/bin/sh: 1: __git_ps1: not found
(base) sirf:\w$

Originally posted by @DANAJK in SyneRBI/SIRF-Exercises#22 (comment)

[KrisThielemans]

that'll probably due to

SIRF-SuperBuild/docker/.bashrc

Lines 12 to 14 in a8a29ed

	curl https://raw.githubusercontent.com/git/git/master/contrib/completion/git-prompt.sh \
	> ~/.git-prompt.sh
	. ~/.git-prompt.sh

@DANAJK maybe you could try to remove the call to git-prompt from your ``docker, .bashrc

[KrisThielemans]

Trickier than expected...

It turns out to be because jupyter opens a shell with /bin/sh, which doesn't understand the fancy PS1 set in .bashrc.

SIRF-SuperBuild/docker/.bashrc

Line 17 in a8a29ed

export PS1='sirf:\w$(__git_ps1)\$ '

However, the .profile (correctly) doesn't read the .bashrc

SIRF-SuperBuild/docker/.profile

Lines 1 to 4 in 32b0126

	if [ -n "$BASH_VERSION" ]; then
	if [ -f "$HOME/.bashrc" ]; then
	. "$HOME/.bashrc"
	fi

Nevertheless, the jupyter terminal does have PS1 (and various SIRF variables which are not set at all)!

My guess is that the jupyter terminal inherits the env from jupyter which was started from bash.

Options for fixing:

• remove the fancy prompt
• (preferred) make sure that jupyter starts bash instead. Some pointers at https://stackoverflow.com/questions/33467098/how-can-the-terminal-in-jupyter-automatically-run-bash-instead-of-sh