Docker small fixes #574
Merged
Docker small fixes #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses SyneRBI#540 (by disabling the git-prompt feature which only works in bash)
jupyter terminals currently use sh, not bash. Best to be safe.
replaces env_ccppetmr.sh
In the previous version /home-away was moved to $HOME. This caused problems with `docker exec` as it expects /home-away to be present. Now we just keep it. Fixes SyneRBI#544 [actions skip]
Fixes SyneRBI#573 [actions skip]
paskino
reviewed
Jun 15, 2021
Comment on lines
+6
to
+10
| libboost-dev libboost-chrono-dev \ | ||
| libboost-filesystem-dev libboost-thread-dev \ | ||
| libboost-date-time-dev libboost-regex-dev \ | ||
| libboost-program-options-dev libboost-atomic-dev \ | ||
| libboost-test-dev libboost-timer-dev \ |
There was a problem hiding this comment.
didn't we decide to remove these packages?
There was a problem hiding this comment.
I copied the list from the VM. Not 100% sure if we still need all of them, but definitely most of them.
The previous version installed all the boost libraries, which is considerably more
|
thanks. feel free to merge (not squash-merge), or tell me to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages if what this does.
@paskino, could you have a quick look?