Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Request] Adminer 4.7.6 #3888

Closed
DigitalBox98 opened this issue Feb 19, 2020 · 8 comments · Fixed by #3894
Closed

[Package Request] Adminer 4.7.6 #3888

DigitalBox98 opened this issue Feb 19, 2020 · 8 comments · Fixed by #3894

Comments

@DigitalBox98
Copy link
Contributor

Name: Adminer
Description: Propose Adminer to latest version 4.7.6

I got it working and connecting to embedded PostgreSQL. If someone is interested let me know (I only have an issue with git and the PR process: I have created a new branch for Adminer but this PR is mixed with a previous one (postgresql))

adminer

@hgy59
Copy link
Contributor

hgy59 commented Feb 23, 2020

@DigitalBox98 did you remove the patch file to enable connection to embedded PostgreSQL - or is such a patch still required?

@DigitalBox98
Copy link
Contributor Author

I have applied the same patch again on this version but I haven't tested if it was OK without it :)

@hgy59
Copy link
Contributor

hgy59 commented Feb 23, 2020

@DigitalBox98 so you adapted the patch file for the current Version? Otherwise the patch cannot be applied due modified source file and the build would fail.

@DigitalBox98
Copy link
Contributor Author

yes correct it was adapted :)

hgy59 added a commit to hgy59/spksrc that referenced this issue Feb 23, 2020
- update adminer to version 4.7.6
- use design "rmsoft_blue" due design "nette" is outdated
- use design (adminer.css) from source package instead of download from git
- add ui wizards to allow configuration of allowed networks in .htaccess
- replace target dir 'share/adminer' by 'web'
- use source package containing externals folder
@hgy59 hgy59 mentioned this issue Feb 23, 2020
3 tasks
@hgy59
Copy link
Contributor

hgy59 commented Feb 23, 2020

@DigitalBox98 and the reason for this patch is written in the patch file:

# See https://github.com/SynoCommunity/spksrc/issues/2662
# Remove the extension pgsql because the extension pgsql does not work with the PostgreSQL server from DSM. The Extension pdo_pgsql works perfectly.

@hgy59
Copy link
Contributor

hgy59 commented Feb 23, 2020

@DigitalBox98 did you use the information in the wiki to connect to the internal postgresql?

@hgy59
Copy link
Contributor

hgy59 commented Feb 23, 2020

@DigitalBox98 in my PR I switched to a different adminer design. As you can see in your screenshot above, the links to select data from tables is missing the icon. It shows select as text instead. Before the update the nette design showed icons here.

@DigitalBox98
Copy link
Contributor Author

To connect to the internal postgresql, I have created an additional admin user (pgadmin) so that I can choose the correct password to have access to all the databases. This part is not included in the package :)
Thanks for the hint about the design icon.

ymartin59 pushed a commit that referenced this issue Mar 22, 2020
* Update adminer #3888

- update adminer to version 4.7.6
- use design "rmsoft_blue" due design "nette" is outdated
- use design (adminer.css) from source package instead of download from git
- add ui wizards to allow configuration of allowed networks in .htaccess
- replace target dir 'share/adminer' by 'web'
- use source package containing externals folder

* incorporate code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants