Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update adminer to v4.7.6 #3894

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Update adminer to v4.7.6 #3894

merged 2 commits into from
Mar 22, 2020

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Feb 23, 2020 •
edited
Loading

Motivation: Adminer is not update since long time ago
Linked issues: closes #3888, fixes #2662

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Remarks

  • update adminer to version 4.7.6
  • use design "rmsoft_blue" due design "nette" is outdated
  • use design (adminer.css) from source package instead of download from git
  • add ui wizards to allow configuration of allowed networks in .htaccess
  • replace target dir 'share/adminer' by 'web'
  • use source package containing externals folder (was missing so far)
  • adminer login comes 403 error  #3343 and adminer install error and URL redirect #2767 are not fixed with this, adminer still depends on apache 2.2

@hgy59
Update adminer SynoCommunity#3888
18da013 
- update adminer to version 4.7.6
- use design "rmsoft_blue" due design "nette" is outdated
- use design (adminer.css) from source package instead of download from git
- add ui wizards to allow configuration of allowed networks in .htaccess
- replace target dir 'share/adminer' by 'web'
- use source package containing externals folder
@hgy59 hgy59 added status/ready-to-merge update request to update existing package labels Feb 23, 2020
ymartin59
ymartin59 requested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor improvements requests

spk/adminer/src/.htaccess Outdated Show resolved Hide resolved
cross/adminer/Makefile Outdated Show resolved Hide resolved
spk/adminer/src/installer.sh Outdated Show resolved Hide resolved
spk/adminer/src/wizard/install_uifile_enu Outdated Show resolved Hide resolved
spk/adminer/src/wizard/upgrade_uifile_enu Outdated Show resolved Hide resolved
@ymartin59 ymartin59 merged commit 417fbe0 into SynoCommunity:master Mar 22, 2020
@ymartin59
Copy link
Contributor

Hello @hgy59 When testing, I faces troubles with application shortcut, probably a lacking reverse proxy setup in Apache 2. May you please provide some configuration details about it at https://github.com/SynoCommunity/spksrc/wiki/Adminer ?

@ymartin59
Copy link
Contributor

@hgy59 In fact package does not declares its dependencies to apache 2.2 and PHP

@ymartin59
Copy link
Contributor

@hgy59 Sorry I cannot get it run properly. Was 404 before PHP installation. So I re-install and now get error 500.

@hgy59
Copy link
Contributor Author

hgy59 commented Mar 22, 2020

@ymartin59 I have no problems with this. The Web Station is configured with back-end-server Apache 2.2 and default PHP 5.6 profile without enabled personal web sites.
In the default PHP 5.6 profile, I have enabled the follwoing extensions (not all related to adminer):

  • gd
  • intl
  • mysql
  • mysqli
  • pdo_dblib
  • pdo_mysql
  • pdo_pgsql
  • pdo_sqlite
  • pgsql
  • sqlite3

I did not change anything related to the web-server on the target device and I am not shure, whether INSTALL_DEP_SERVICES = apache-web does include PHP installation.

May be your package log has further information?

@hgy59
Copy link
Contributor Author

hgy59 commented Mar 22, 2020

@ymartin59 After deactivation of all PHP 5.6 extenstions.
, the Adminer UI still works.
When connection to a mysql db the expected error appears None of the supported PHP extensions (MySQLi, MySQL, PDO_MySQL) are available.

@hgy59
Copy link
Contributor Author

hgy59 commented Mar 22, 2020

@DigitalBox98 can you please test Adminer as it is merged into the master branch.
I cannot reproduce the issues found by @ymartin59

@DigitalBox98
Copy link
Contributor

I confirm the issue raised by ymartin59 (I'm using Apache 2.4)

After looking in details, Apache 2.4 is using another format for .htaccess file
See : https://httpd.apache.org/docs/2.4/en/howto/access.html

I've change .htaccess content with the below line :
Require ip 192.168.1.39

With that new file, it works fine and I can connect to PostgreSQL 11.6 located on my NAS :)

@hgy59 hgy59 deleted the update_adminer branch April 9, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymartin59 ymartin59 ymartin59 approved these changes

Assignees
No one assigned
Labels
update request to update existing package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request] Adminer 4.7.6 Adminer
3 participants
@hgy59 @ymartin59 @DigitalBox98