-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSM 5] Update OctoPrint to 1.3.2 #2676
Conversation
921906b
to
093ff0c
Compare
So far so good on @Dr-Bean great work on the new wheel approach! It really makes maintaining Python packages a lot easier to do. Some questions before I continue:
|
If Octoprint can be built directly as a wheel (looks like it: no patches, no build-time dependencies), then the cross package should be removed. You can add the download site directly to the requirements file if I'm not mistaken. DSM6 compatibility for Octoprint was added into the The current version of |
I was looking at the be04bd9 commit. Before I go and try to compile this myself, am I understanding correctly that there is now an octoprint version that works on dsm6? If so, how could I access it? Thank you, tarek : ) |
@tareko the DSM6 branch doesn't have my changes yet. I'll open up a separate PR for DSM6 once I finish up and get this one merged. |
I can confirm that fixing @Dr-Bean I applied your advice and the cross package is now gone. Let me know if you find anything else I should change before the merge. |
27ccfbd
to
f5bd7a9
Compare
f5bd7a9
to
4c91f81
Compare
6b6cde6
to
b0652b2
Compare
So I've looked at the DSM6 version for Octoprint and merging this change should be as easy as some selective cherry-picking. I'll get on it once I'll have some spare time and my dev machine at hand. |
@markbastiaans any progress or time to take a look at this at all, lately? |
any progress? how do I get Octoprint 1.3.4 to run on DSM6.0? anyone? |
Motivation: OctoPrint is in need of a new version. I'll update this PR as I make progress.
Linked issues: I aim to make the package DSM6 compatible (#2661) and solve #2386 and #2599.
Checklist
netifaces
issue for some archsarch-evansport
completed successfullyall-supported
completed successfully