Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update octoprint to v1.7.2 and Python38 #4096

Merged
merged 11 commits into from
Nov 6, 2021
Merged

update octoprint to v1.7.2 and Python38 #4096

merged 11 commits into from
Nov 6, 2021

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Aug 2, 2020 •
edited
Loading

Motivation: Octoprint spk is really outdated and does not work
Linked issues: closes #3128, closes #3966, may close #2676

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade is not supported due to versioning scheme change, all older versions deleted from repository, further upgrade will be supported
  • New installation of package completed successfully

Remarks

package upgrade is not provided as the versioning scheme changed (you cannot upgrade from 20160321-4 to 1.4.0-5 as this is a downgrade)
I propose to retire the old packages (remove from the repository) as they did not really work and were beta anyway.

@hgy59
Copy link
Contributor Author

hgy59 commented Aug 2, 2020

Is there any octoprint user with a web cam to validate the ffmpeg integration ❓

ymartin59
ymartin59 reviewed Aug 4, 2020
View reviewed changes
ymartin59
ymartin59 reviewed Oct 27, 2020
View reviewed changes
@hgy59 hgy59 changed the title update octoprint to v1.4.0 and Python3 update octoprint to v1.4.2 and Python3 Oct 27, 2020
@hgy59 hgy59 added the update request to update existing package label Oct 27, 2020
ymartin59
ymartin59 requested changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really recommend to migrate dsm-control.sh and installer.sh to use generic service support https://github.com/SynoCommunity/spksrc/wiki/Service-Support
It may help for next DSM 7 support/upgrade

@hgy59
Copy link
Contributor Author

hgy59 commented Oct 30, 2020

I really recommend to migrate dsm-control.sh and installer.sh to use generic service support https://github.com/SynoCommunity/spksrc/wiki/Service-Support
It may help for next DSM 7 support/upgrade

@ymartin59 WIP, but service does not start yet and I am out for some days...

This was referenced Dec 9, 2020
Closed
Closed
@ymartin59
Copy link
Contributor

@hgy59 Have you received users' feedback about this package? Would it be OK to publish?

@hgy59
Copy link
Contributor Author

hgy59 commented Dec 21, 2020

@hgy59 Have you received users' feedback about this package? Would it be OK to publish?

No feedbak yet.
I tried to replace install scripts by service-setup.sh but didn't succeed (package does not start, at least on ppc853x-5.2)
But if you want get rid of pyhton2 dependent packages you may publish.

@hgy59 hgy59 changed the title update octoprint to v1.4.2 and Python3 update octoprint to v1.5.2 and Python3 Dec 29, 2020
This was referenced Mar 24, 2021
Closed
Closed
@hgy59 hgy59 force-pushed the update_octoprint branch from 9eab4e8 to 3ddc93f Compare March 24, 2021 19:46
@hgy59 hgy59 changed the title update octoprint to v1.5.2 and Python3 update octoprint to v1.5.3 and Python3 Mar 24, 2021
@willuk2010
Copy link

willuk2010 commented Aug 11, 2021 •
edited
Loading

Any way to get this working on DSM 6.2.4-25556 on my DS1511+ ?

Many thanks

@hgy59 hgy59 changed the title update octoprint to v1.5.3 and Python3 update octoprint to v1.7.0 and Python38 Oct 24, 2021
@hgy59
Copy link
Contributor Author

hgy59 commented Oct 24, 2021 •
edited
Loading

Any way to get this working on DSM 6.2.4-25556 on my DS1511+ ?

Many thanks

Just updated to the latest version and python38. Can you please give it a try?
When github build action is sucessfully terminated, you can download the built packages as artifacts.

This was referenced Oct 27, 2021
Merged
Merged
@hgy59
Copy link
Contributor Author

hgy59 commented Oct 31, 2021

@ymartin59 this is now fully migrated to use the generic service installer.

still needs some investigation with the cross compilation of the wheels

@hgy59
Copy link
Contributor Author

hgy59 commented Nov 1, 2021

This will prevent automated update in Package Center.
But I prefer that way. Users still running old version installed on DSM 5 before upgrade to DSM 6 will have to download and install manually

I have now deactivated all existing octopus versions in the sc repository. Hopefully those will disapear in the package center on DSM before we will publish this updated version.
Otherwise it will display an update available with version 20160321-4 when you have installed version 1.7.1-6 ....

@hgy59 hgy59 changed the title update octoprint to v1.7.0 and Python38 update octoprint to v1.7.2 and Python38 Nov 2, 2021
@hgy59
Copy link
Contributor Author

hgy59 commented Nov 2, 2021

arch-88f6281.6.1 will get fixed with #4949 ...

hgy59 added 9 commits November 3, 2021 22:54
@hgy59
update octoprint to v1.4.0
6641ca7 
- update octoprint and use python3
- update dependencies
@hgy59
update octoprint to v1.4.2
ff9cb55
@hgy59
add changelog
5183697
@hgy59
Update octoprint to v1.5.2
f209255
@hgy59
update requirements for octoprint v1.5.2
dbac85a
@hgy59
update ocroprint to v1.5.3
abf98e1
@hgy59
update octoprint to v1.6.0
d85ca56
@hgy59
update octoprint to v1.7.0
83bcc78 
- use generic service definition
- add DSM 7 compatibility
- use python38
@hgy59
octoprint: update to v1.7.2
36a517f 
- just another bugfix release for octoprint
- split requirements for pure-python and cross-compile
- cleanup generic service installer settings
hgy59 added 2 commits November 3, 2021 23:14
@hgy59
revert changes in homeassistant
e0aba18 
- apply update in octoprint instead of homeassistant package
@hgy59
fix digests
29f43ae
@hgy59 hgy59 mentioned this pull request Nov 5, 2021
Merged
37 tasks
@hgy59 hgy59 merged commit a15cdf6 into SynoCommunity:master Nov 6, 2021
@hgy59 hgy59 deleted the update_octoprint branch November 6, 2021 10:42
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Nov 6, 2021
AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
@hgy59
update octoprint to v1.7.2 and Python38 (SynoCommunity#4096)
fdfeba9 
* update octoprint to v1.4.0
- update octoprint and use python3
- update dependencies
* update octoprint to v1.4.2
* add changelog
* Update octoprint to v1.5.2
* update requirements for octoprint v1.5.2
* update ocroprint to v1.5.3
* update octoprint to v1.6.0
* update octoprint to v1.7.0
- use generic service definition
- add DSM 7 compatibility
- use python38
* octoprint: update to v1.7.2
- just another bugfix release for octoprint
- split requirements for pure-python and cross-compile
- cleanup generic service installer settings
* revert changes in homeassistant
- apply update in octoprint instead of homeassistant package
* fix digests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymartin59 ymartin59 ymartin59 requested changes

Assignees
No one assigned
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager) update request to update existing package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to execute Octoprint - Synology 216+ Octoprint - service cannot be started
3 participants
@hgy59 @ymartin59 @willuk2010