CouchPotato - Generic Service approach #3092

Safihre · 2018-01-11T12:26:17Z

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully
New installation of package completed successfully

ymartin59 · 2018-01-13T20:21:18Z

spk/couchpotatoserver/src/service-setup.sh

+service_postinst ()
+{
+    # Create a Python virtualenv
+    ${VIRTUALENV} --system-site-packages ${SYNOPKG_PKGDEST}/env >> ${INST_LOG} 2>&1


OK for Python environment, but am I wrong or pip install from requirements.txt file is required and lacking ?

Couchpotato has no requirements, everything comes included :)

OK so in that specific case, is a pip environment really required ??

Not really, but it's considered best practice to make sure one package can't mess with anything. And doesn't take a lot of space so seems like a good idea always.

ymartin59 · 2018-01-13T20:22:11Z

I will propose a french translation there too.

ymartin59 · 2018-01-13T20:30:47Z

Please change Git clone URL to https://github.com/CouchPotato/CouchPotatoServer.git

ymartin59 · 2018-01-13T20:32:58Z

spk/couchpotatoserver/Makefile


 DEPENDS =
 SPK_DEPENDS = "python>2.7.3-3:git"

 MAINTAINER = Diaoul
 DESCRIPTION = CouchPotato is an automatic NZB and torrent downloader for movies. You can keep a \"want to watch\"-list and it will search for NZBs/torrents of these items every X hours. Once a correct release is found, matching the correct quality, it will send it to SABnzbd/NZBGet or download the .nzb or .torrent to a specified directory. The downloaded movie can then be automatically moved and renamed to your liking as well as indexed by your DiskStation.
 DESCRIPTION_FRE = CouchPotato permet le téléchargement automatique de films via NZB ou torrent. Vous pouvez créer une \\\"liste de films à voir\\\", CouchPotato ira alors automatiquement rechercher les NZBs ou torrents correspondants toutes les X heures. Une fois qu\\\'une release correcte est trouvée, correspondant à la qualité demandé, elle sera ajouté a SABnzbd/NZBGet, ou téléchargée sous forme de .nzb ou de .torrent dans le répertoire indiqué. Les films téléchargés peuvent être déplacé et renommés selon vos préférences ainsi qu\\\'indexés par votre DiskStation.
-DESCRIPTION_SPN = CouchPotato es un sistema automático de descarga de peliculas via NZB y torrent. Puedes tener una \"lista de películas para ver\" y el sistema buscará automáticamente cada X horas. Cuando el release es encotrado con la calidad que especificaste el sistema la enviará al programa de descargas SABnzbd/NZBGet/Transmision o descargá el .nzb o .torrent al directorio que especifiques. Cuando la pelicula se termine de descargar será movida y renombrada automaticamente a tu gusto, además de ser indexada por tu DiskStation. 
-ADMIN_PORT = 5050
+DESCRIPTION_SPN = CouchPotato es un sistema automático de descarga de peliculas via NZB y torrent. Puedes tener una \"lista de películas para ver\" y el sistema buscará automáticamente cada X horas. Cuando el release es encotrado con la calidad que especificaste el sistema la enviará al programa de descargas SABnzbd/NZBGet/Transmision o descargá el .nzb o .torrent al directorio que especifiques. Cuando la pelicula se termine de descargar será movida y renombrada automaticamente a tu gusto, además de ser indexada por tu DiskStation.


I just wonder why spain translation DESCRIPTION_SPN is marked as changed

I think something with whitespace probably.

Right. Trailing white space was removed

Safihre · 2018-01-14T14:57:32Z

@ymartin59 Will wait for your French translations then and update all at once. Maybe you can post them in the Sabnzbd PR since most texts overlap and I can do 1 big update of the PRs.

ymartin59 · 2018-01-18T07:40:57Z

spk/couchpotatoserver/Makefile

 SPK_ICON = src/couchpotatoserver.png
-DSM_UI_DIR = app

 DEPENDS =
 SPK_DEPENDS = "python>2.7.3-3:git"


Is there any chance that this package does not work on previous python package versions ? If so probably dependency has to be set to new version only

I would highly doubt it, but maybe we can ask the people reporting problems now to test the new packages? (since we already have their attention)
This way we get feedback and know for sure.

Safihre · 2018-02-12T11:03:53Z

@ymartin59 I incorporated the sc-media -> sc-download code into this PR.
I also found that in the service.installer some if statements had at the end &> /dev/null, so they would always return empty, although it didn't really affect the results it seems.
I fixed that too.

This PR doesn't really depend on anything, so if this is merged I can incorporate the same code into Sonarr/Radarr/Sickbeard/Sickbeard-custom and we can get things published again!

Safihre · 2018-02-15T06:55:58Z

@ymartin59 did you have time to look at this code that I added for dealing with the sc-media?

Safihre · 2018-02-19T15:13:14Z

Tested this extensively today and turns out the code was pretty wrong.
Corrected it now and applied it to Couchpotato, Radarr and Sonarr.
After this is merged, I will also add it to #3093 for Sickrage and Sickbeard-custom.

Safihre force-pushed the just-cp branch 2 times, most recently from d55f49f to db03e71 Compare January 12, 2018 09:33

m4tt075 mentioned this pull request Jan 12, 2018

Meta: DSM6 compatibility of packages with user privilege issues #2904

Closed

ymartin59 reviewed Jan 13, 2018

View reviewed changes

ymartin59 added the status/work-in-progress label Jan 13, 2018

ymartin59 reviewed Jan 13, 2018

View reviewed changes

ymartin59 reviewed Jan 18, 2018

View reviewed changes

Safihre force-pushed the just-cp branch 3 times, most recently from c187e42 to 653d73f Compare February 12, 2018 11:02

Safihre mentioned this pull request Feb 12, 2018

Service Support: add background command execution #3123

Merged

Safihre mentioned this pull request Feb 18, 2018

Beta / Test packages for DSM 6 #3138

Closed

Safihre force-pushed the just-cp branch from 653d73f to c818042 Compare February 19, 2018 15:11

Safihre requested a review from ymartin59 February 19, 2018 15:13

Safihre added status/needs-review and removed status/work-in-progress labels Feb 19, 2018

Safihre mentioned this pull request Feb 21, 2018

Add set_unix_permissions and syno_user_add_to_legacy_group #3161

Merged

Safihre force-pushed the just-cp branch 3 times, most recently from 73a67dc to 072cdeb Compare February 23, 2018 08:16

Safihre added 2 commits February 23, 2018 09:24

CouchPotato - Generic Service approach

229a9b3

CouchPotato-custom - Generic Service approach

2d7108c

Safihre force-pushed the just-cp branch from 072cdeb to 2d7108c Compare February 23, 2018 08:25

Safihre merged commit cf6acc4 into SynoCommunity:master Feb 23, 2018

Safihre deleted the just-cp branch February 23, 2018 13:02

ymartin59 added status/to-publish and removed status/needs-review labels Feb 23, 2018

ymartin59 removed the status/to-publish label May 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CouchPotato - Generic Service approach #3092

CouchPotato - Generic Service approach #3092

Safihre commented Jan 11, 2018

ymartin59 Jan 13, 2018

Safihre Jan 13, 2018

ymartin59 Jan 15, 2018

Safihre Jan 15, 2018

ymartin59 commented Jan 13, 2018

ymartin59 commented Jan 13, 2018

ymartin59 Jan 13, 2018

Safihre Jan 13, 2018

ymartin59 Jan 14, 2018

Safihre commented Jan 14, 2018 •

edited

Loading

ymartin59 Jan 18, 2018

Safihre Jan 18, 2018

Safihre commented Feb 12, 2018

Safihre commented Feb 15, 2018

Safihre commented Feb 19, 2018

CouchPotato - Generic Service approach #3092

CouchPotato - Generic Service approach #3092

Conversation

Safihre commented Jan 11, 2018

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ymartin59 commented Jan 13, 2018

ymartin59 commented Jan 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Safihre commented Jan 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Safihre commented Feb 12, 2018

Safihre commented Feb 15, 2018

Safihre commented Feb 19, 2018

Safihre commented Jan 14, 2018 •

edited

Loading