Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SiCKRAGE - Generic Service approach #3093

Merged
merged 2 commits into from
Feb 23, 2018
Merged

SiCKRAGE - Generic Service approach #3093

merged 2 commits into from
Feb 23, 2018

Conversation

Safihre
Copy link
Contributor

@Safihre Safihre commented Jan 11, 2018

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@Safihre
Copy link
Contributor Author

Safihre commented Jan 12, 2018

For backwards compatibility I guess these (sonarr/sickrage/couchpotato) should all be sc-media..
Still kinda strange, since they clearly couple to sc-download packages.
I will change this.

@m4tt075 m4tt075 mentioned this pull request Jan 12, 2018
Closed
@ymartin59
Copy link
Contributor

I also wonder what are expected usage of these two distinct groups sc-media and sc-download. A quick usage inventory in packages should help to guess a policy and then fix those that do not match.

@ymartin59
Copy link
Contributor

I have to submit a french translation too

@Safihre
Copy link
Contributor Author

Safihre commented Jan 14, 2018

It seems sc-media was assigned to packages doing something with media files, regardless if they came from download providers.
It's too late to change now, because if previous version of any of these packages (Sonarr/CouchPotato/Sickrage/etc) was already installed, switching to sc-download would not allow these packages to access the files they manages before anymore. Bit annoying and not so user friendly situation, both cases actually..

@Safihre
Copy link
Contributor Author

Safihre commented Jan 15, 2018

Added sickbeard-custom to this one. It's 98% the identical code.
Minus the requirements installation of SickRage that is not needed for SickBeard.

@Safihre Safihre mentioned this pull request Feb 19, 2018
Merged
3 tasks
@Safihre Safihre force-pushed the sickrage-fix branch 4 times, most recently from 65dd754 to f9707bb Compare February 22, 2018 16:26
@Safihre Safihre merged commit 4fcb241 into SynoCommunity:master Feb 23, 2018
@Safihre Safihre deleted the sickrage-fix branch February 23, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Safihre @ymartin59