Sickchill DSM 6, 7 #4901
Sickchill DSM 6, 7 #4901
Conversation
| PRE_CONFIGURE_TARGET = dante_pre_configure | ||
|
|
||
| include ../../mk/spksrc.cross-cc.mk | ||
|
|
||
| .PHONY: dante_pre_configure | ||
| dante_pre_configure: | ||
| $(RUN) autoreconf -i -f -v |
There was a problem hiding this comment.
This addition along with the patch allows it to build on DSM7. Otherwise it does the following:
$ make arch-armv7-7.0
...
checking getaddrinfo() error symbols... configure: error: in `/home/spksrc/BKSteve/spksrc/cross/dante-sockd/work-armv7-7.0/dante-1.4.2':
configure: error: error: getaddrinfo() error value count too low
See `config.log' for more details
make[2]: *** [../../mk/spksrc.configure.mk:50: configure_target] Error 1
There was a problem hiding this comment.
That's very interesting and somewhat odd.
There was a problem hiding this comment.
Indeed but it's the only workaround I was able to find online... Feel free to figure a better option, at least on master it now build ok with it.
There was a problem hiding this comment.
I'm open to any solutions, I'm still at the bottom of the S curve with this.
There was a problem hiding this comment.
I don't have the patch for dante-sockd and I can't get that error message when building armv7-7.0 like you show.
If make armv7 then I get the cffi error and second build after spkclean is good.
I'm a little confused now.
There was a problem hiding this comment.
My guess is that your tree wasn't rebased against master as this update to version 1.4.3 is the last commit I pushed in and therefore your tree is removing this last commit on master.
The error I'm referring to is happening on all DSM7 builds and was caught on github-action from #4797.
There was a problem hiding this comment.
So you could just discard all the dante changes and use what's on master.
There was a problem hiding this comment.
Please all dante related changes as this is most probably due to your branch not being rebased against master as this was merged part of PR #4898 and yours removes it entirely and it isn't related to Sickchill at all.
|
I tried a build with the Python 3.8.12 PR and still had cffi issues with 88f5281 most others were able to compile first build |
|
Presuming you mean Maybe its within Sickchill |
|
Also, you haven't rebased against master... |
| @@ -86,8 +86,8 @@ python38_post_install: $(WORK_DIR)/python-cc.mk | |||
| @$(RUN) $(PYTHON_NATIVE) -m crossenv $(STAGING_INSTALL_PREFIX)/bin/python$(PKG_VERS_MAJOR_MINOR) $(WORK_DIR)/crossenv/ | |||
| . $(WORK_DIR)/crossenv/bin/activate && $(RUN) wget https://bootstrap.pypa.io/get-pip.py -O - | build-python | |||
| . $(WORK_DIR)/crossenv/bin/activate && $(RUN) wget https://bootstrap.pypa.io/get-pip.py -O - | python | |||
| . $(WORK_DIR)/crossenv/bin/activate && $(RUN) build-pip install "setuptools==44.1.0" "wheel==0.36.2" "cffi==1.14.5" | |||
There was a problem hiding this comment.
If I were you I would really avoid using >= mechanisms. It would make the build non repeatables.
Similarly it would be worth updating all cross/* equivalents to the same versions to be on the safe side.
There was a problem hiding this comment.
Actually, this is superseeded by #4902 and should be removed from your PR.
There was a problem hiding this comment.
Yes, the >= was an ugly work around during the testing and the errors being thrown that's why I mentioned in first post.
Now 3.8.12 is in master I'll update and rebase instead of using the combination of clone of th0ma7 3.8.12 branch from his repo along with my sickchill copied to that clone.
|
Still active, just deleted and recreated branch. Here's my log of But does this constitute an actual issue? As a spk was built, so it should install and load.
|
To get SickChill a functional SPK in SynoCommunity
Relates to
#4856 #4870 #4867 #4743 #4835
The build is not perfect and has issues due to Python38 build causing cffi package build errors for a number of architectures, along with some rust build issues from that, there is also a lxml issue with man pages throwing an error in the build process.
To overcome most of the Python38 issues (other than cffi) the cross makefile lines 89 & 90 were changed to use newest versions of other packages required to build
"setuptools>=58.0.0" "wheel>=0.36.2" "cffi>=1.14.5". Yes going >= was what i chose.I'm sure there's a way to do this without affecting everybody else using cross/python38 and ask for input from others.
To build the spk is a 3 step process make
all-supportedthenspkcleanfollowed byall-supportedprovides the 11/11 architectures and DSM 6&7 builds which are fully functional, load and work.All the builds and testing are here https://github.com/SickChill/SickChill/issues/7504 if you wish to check anything out.
This pull request has makefile numbered as version 3 for SynoCommunity sequence which is the testing 20210729-17.spk packages in 7504.
Checklist
all-supportedcompleted successfully after spkclean!