-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sickchill 6 7 rebuild with Py3.8.12-6 #4920
Conversation
version 3 correction
Tried to get this to function with 3.8.11 and it threw the following on my DS412+ x64 based machine.
Which is more likely because I moved PyNaCl from Will now wait for 3.8.12 official release and update my DSM before further testing. |
Now available https://synocommunity.com/package/python38 |
Alas same error I did a pip install of pynacl just to see and it gave me a |
@BKSteve I'll try to have a look at it later this week. I have a really busy week ahead with limited cycles, worst case I should find some time over the next week-end. |
OK, so going through the logs it's actually in the cross/poetry build where it pulls some requirements from somewhere with |
For information on the installation and upgraded python 3.8.12
Similarly when building Sickchill it did similar with Looking at the Python 3.8.12 install log section
I don't know when this
EDIT: Sorry should have look at issues first as already in #4925 |
Not entirely sure that the old 3.8.11 didn't have 0.0.0 but it was broken on cffi on all non-x64 arches and may have been hiding other build issues... I was able to create a workaroud where I manage pure-python vs cross-compiled python wheels slightly differently. I think solution looks promising as I was able to solve all my issues related to python38 3.8.12 using tvheadend as target sub-package. Tentative solution currently is in PR #4921 |
But yes much better to fix the |
My testing shows working on x64 6.1, 7.0 |
Good! And heads-up, I just released the updated |
Revert to v3 from test 21.
Changed the version from my testing 21 number to 3 for release. Edit: Yes, 3.8.12-6 is what the latest edits are based on. |
With I think it's ready for release 3. |
Any chance this can get rolled out? Edit: tag for somebody to release. 20211102 |
The poetry failure is indeed odd. I was able to easily add it to python310 under #4951 |
. $(CROSSENV) && $(RUN) _PYTHON_HOST_PLATFORM="$(TC_TARGET)" CFLAGS="$(CFLAGS) -I$(STAGING_INSTALL_PREFIX)/$(PYTHON_INC_DIR) $(WHEELS_CFLAGS)" LDFLAGS="$(LDFLAGS) $(WHEELS_LDFLAGS)" $(PIP_WHEEL) --no-build-isolation --requirement $(WHEELHOUSE)/$(WHEELS_CROSS_COMPILE) ; \ | ||
. $(CROSSENV) && $(RUN) _PYTHON_HOST_PLATFORM="$(TC_TARGET)" CFLAGS="$(CFLAGS) -I$(STAGING_INSTALL_PREFIX)/$(PYTHON_INC_DIR) $(WHEELS_CFLAGS)" LDFLAGS="$(LDFLAGS) $(WHEELS_LDFLAGS)" pip $(PIP_WHEEL_ARGS) --no-build-isolation --requirement $(WHEELHOUSE)/$(WHEELS_CROSS_COMPILE) ; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@th0ma7 Ah found it! pip
and $(PIP)
are not the same. Or at least pip
works and $(PIP)
doesn't
# dosn't work
. $(CROSSENV) && $(RUN) _PYTHON_HOST_PLATFORM="$(TC_TARGET)" CFLAGS="$(CFLAGS) -I$(STAGING_INSTALL_PREFIX)/$(PYTHON_INC_DIR) $(WHEELS_CFLAGS)" LDFLAGS="$(LDFLAGS) $(WHEELS_LDFLAGS)" $(PIP) wheel $(PIP_ARGS) --wheel-dir $(WHEELHOUSE) --no-build-isolation --requirement $(WHEELHOUSE)/$(WHEELS_CROSS_COMPILE) ; \
# works
. $(CROSSENV) && $(RUN) _PYTHON_HOST_PLATFORM="$(TC_TARGET)" CFLAGS="$(CFLAGS) -I$(STAGING_INSTALL_PREFIX)/$(PYTHON_INC_DIR) $(WHEELS_CFLAGS)" LDFLAGS="$(LDFLAGS) $(WHEELS_LDFLAGS)" pip wheel $(PIP_ARGS) --wheel-dir $(WHEELHOUSE) --no-build-isolation --requirement $(WHEELHOUSE)/$(WHEELS_CROSS_COMPILE) ; \
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we in a virtual environment? aka CROSSENV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @th0ma7 I'm going to revert the 2 files (mk/spksrc.common.mk, mk/spksrc.wheel.mk) from 98dc6b4#diff-b2c976fb01fa035ca37be782346b9773732c78d931102770d1a305d9cfdc6a06
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have to go over the various changes you did (any left or not?) so my other PR doesn't get too funky neither.
I'm glad you have sorted it out, good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reading it I don't understand:
- why would it work using
pip
instead of$(PIP)
when really it's the same thing? If not we need to find out what's the difference and why (and probably add a comment on top ofPIP ?= pip
to explain it) - Otherwise my "guess" is that the re-ordering in
PIP_WHEEL_ARGS
is what fixed the issue. On the other hand, if it was onlypip
then why changing that? - Currently
PIP_DONWLOAD
callsPIP_ARGS
which is now existent (probably easy to fix)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I rebase against master my PR, can you double-check this and confirm a few things? Otherwise I fear I may break things back for sickchill
while fixing PIP_DOWNLOAD
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, just wow!
@publicarray I've been double-checking and I just don't get it... it does solves the issue no matter why?
I've checked the following:
which $(PIP) ;\
which pip ;\
$(MSG) $(PIP_WHEEL) ;\
$(MSG) $(PIP) $(PIP_WHEEL_ARGS) ;\
$(MSG) pip $(PIP_WHEEL_ARGS) ;\
Which gives this:
/usr/local/bin/pip
/usr/local/bin/pip
===> pip wheel --no-binary :all: --cache-dir /home/spksrc/python310-fixes/spksrc/spk/sickchill/../../distrib/pip --no-deps --wheel-dir /home/spksrc/python310-fixes/spksrc/spk/sickchill/work-x64-7.0/wheelhouse
===> pip wheel --no-binary :all: --cache-dir /home/spksrc/python310-fixes/spksrc/spk/sickchill/../../distrib/pip --no-deps --wheel-dir /home/spksrc/python310-fixes/spksrc/spk/sickchill/work-x64-7.0/wheelhouse
===> pip wheel --no-binary :all: --cache-dir /home/spksrc/python310-fixes/spksrc/spk/sickchill/../../distrib/pip --no-deps --wheel-dir /home/spksrc/python310-fixes/spksrc/spk/sickchill/work-x64-7.0/wheelhouse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found it!!!!! 😄
- The defined
$(PIP)
inspksrc.common.mk
points to the native binary. - When direct
pip
is called with. $(CROSSENV) && $(RUN) ...
it points to cross-environment as the path gets changed such as:
$ cat work-x64-7.0/crossenv/bin/activate
. /home/spksrc/python310-fixes/spksrc/spk/sickchill/work-x64-7.0/crossenv/cross/bin/activate
export PATH=/home/spksrc/python310-fixes/spksrc/spk/sickchill/work-x64-7.0/crossenv/bin:$PATH
Resulting in:
::::::::::::::
work-x64-7.0/pip.1
::::::::::::::
pip 21.3 from /home/spksrc/python310-fixes/spksrc/native/python38/work-native/install/usr/local/lib/python3.8/site-packages/pip (python 3.8)
::::::::::::::
work-x64-7.0/pip.2
::::::::::::::
pip 21.3 from /home/spksrc/python310-fixes/spksrc/spk/sickchill/work-x64-7.0/crossenv/build/lib/python3.8/site-packages/pip (python 3.8)
Thanks for sorting out the |
Thanks @BKSteve, Thanks for hanging in there. |
Anyway once this build is done I think it's time to publish. |
|
Thanks. haha, you did good 🐰 I'm also still learning more coding (rust and react) |
@BKSteve did you have the following error when installing sickchill?
|
No, I just updated those numbers and it loaded and worked. |
I don't think my build environment was clean... 🙈 |
my new clean install threw something else at me
But also loaded and running. Perhaps I should push the two |
Before you do that I'm waiting for my build with just changing |
Yes, I'm just building with 2.4.7 too, just the one change. |
|
Thanks, I just finished compiling this one too. |
The next build worked without error. Can you make these 2 changes to the |
Yea will do 👍 |
Thanks for help! |
Think you can close #4856 too. |
Thanks, I'll wait until the builds are done. |
Continuation of #4901 after Py 38.12 #4902
All 11/11 packages built on first pass. Errors remain in the logs pertaining to
cffi
andsetuptools_rust
during thecross/poetry
build part of the process for88f6281-6.1, armv7-6.1 and 7.0, hi3535-6.1, qoriq-6.1
With
evansport
givinglibz.so: cannot open shared object file: No such file or directory
error during the Py3.8.12 build process.PS. This is labelled as version 18 as that was my test, probably should be 2 or 3.