pyhon3* wheel fixes + TVH Fall 2021 update & Fix 403 Forbidden #4921
Conversation
1. Use -C flag at startup to manage the initial creation of the admin user account using built-in app functionality instead of playing with wizard. This allow removing wizard entirely along with POST_STRIP_TARGET. 2. Enable logs using the -l flag 3. Update to version from October 16th 2021 (git 1ee9c5b) 4. Fix SPK_DEPENDS to add ffmpeg on top of python38
1. Use -C flag at startup to manage the initial creation of the admin user account using built-in app functionality instead of playing with wizard. This allow removing wizard entirely along with POST_STRIP_TARGET. 2. Enable logs using the -l flag 3. Update to version from October 16th 2021 (git 1ee9c5b) 4. Fix SPK_DEPENDS to add ffmpeg on top of python38
mk/spksrc.wheel.mk
Outdated
| fi | ||
|
|
||
| build_wheel_target: $(PRE_WHEEL_TARGET) | ||
| @if [ ! -z "$(WHEELS)" ] ; then \ | ||
| $(foreach e,$(shell cat $(WORK_DIR)/python-cc.mk),$(eval $(e))) \ | ||
| if [ ! -z "$(CROSS_COMPILE_WHEELS)" ] ; then \ | ||
| if [ -f "$(WORK_DIR)/wheelhouse/cross-requirements.txt" ]; then \ |
There was a problem hiding this comment.
So what happens here? How does the rename from requirements to cross-requirements fixes things?
There was a problem hiding this comment.
its not only a rename but rather telling to cross-compile the ones in cross and "python" compile the other ones by default (e.g. pure). Again for reference #4925 (comment)
Good catch. I'll check if I can easily force adding a new line to alleviate that. EDIT: Added a fix for that, can you give that a shot and confirm it works as expected? Also, @Safihre besides that issue, where your packages good and fully functional applied over this branch and using python38 from here? |
This is to address finding from @Safihre: SynoCommunity#4921 (comment)
|
@Safihre related to your previous comment:
How do you figure out what's pure vs cross (other than looking for build failures)? Using that, would you have a moment to help out and revisit this PR in order to move wheels from cross to pure in affected packages when you see fit so only a minimal set of cross wheels remain? |
I looked at the pypi.org pages for each package, if they are binary then they usually have many |
|
I installed the @hgy59 or @publicarray Looks good to me, maybe you have any more comments?
|
|
Thnx @Safihre this is much appreciated.
|
|
@Safihre I've nwo pushed all the changes (with exception of |
I rebased my SABnzbd PR on this one and it works as expected. |
|
Great, thnx for this initial feedback. |
Yes, it's used by a lot of packages (13 from what I see). Even more (18) use it's big brother: |
|
Python 3 & 38 are very useful and important packages why not pop in |
|
@BKSteve good point although conceptually there is more to that:
All in all there is a point where we have to get things out and wait for the right time for subsequent changes. As such I tend to agree with @Safihre , lets get this one out and fix multiple issues right away, and leave the remaining for later. |
|
Tested and works as expected :) |
th0ma7
added
status/published
Yep, so much time spent building Python with all it's own cross and native items, it would be great if this was a |
Motivation: Update
tvheadendto latest available version and:-Cflag at startup to manage the initial creation of the admin user account using built-in app functionality instead of playing with wizard. This allow removing wizard entirely along withPOST_STRIP_TARGET.-lflag1ee9c5b)SPK_DEPENDSto addffmpegon top ofpython38tvheadendspecific changes from4797to its own PRIMPORTANT: While investigating I also found issues with latest python38 package (ref. #4925). Currently this PR also contains important fixes for python3* to work properly.
Linked issues: #4758 and #3707 for
tvheadendand created #4925 while investigatingChecklist
all-supportedcompleted successfully