Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node.js: add node.js v16 #5037

Merged
merged 2 commits into from
Jan 4, 2022
Merged

node.js: add node.js v16 #5037

merged 2 commits into from
Jan 4, 2022

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Jan 2, 2022 •
edited
Loading

Motivation: Synology provides only Node.js v12 and v14 but not the current LTS v16
Linked issues: closes #5013

Checklist

  • Build rule all-supported completed successfully (DSM 7 only)
  • n/a Package upgrade completed successfully
  • New installation of package completed successfully

Remarks

  • former nodejs (v10) package removed
  • only DSM 7 is supported

@hgy59
node.js: add node.js v16
e6bed70 
- add node.js v16 as dedicated package
- remove former nodejs (v10) package
This was referenced Jan 2, 2022
Closed
Open
@hgy59 hgy59 merged commit ce16d8f into SynoCommunity:master Jan 4, 2022
@hgy59 hgy59 deleted the add_nodejs_v16 branch January 4, 2022 17:47
@th0ma7
Copy link
Contributor

th0ma7 commented Jan 4, 2022

Just a thought, before publishing (this and or anything else) I guess #5046 may be needed.

@hgy59
Copy link
Contributor Author

hgy59 commented Jan 4, 2022

Just a thought, before publishing (this and or anything else) I guess #5046 may be needed.

Only a few packages need wildecard in PLIST

  • cross/bcrypt/PLIST
  • cross/boost/PLIST
  • cross/cffi/PLIST
  • cross/dnscrypt-proxy/PLIST
  • cross/imagemagick/PLIST
  • cross/pip/PLIST
  • cross/pip_py2/PLIST
  • cross/PyNaCl/PLIST
  • cross/python2/PLIST
  • cross/rabbitmq/PLIST
  • cross/setuptools/PLIST
  • cross/setuptools_py2/PLIST

nodejs_v16 does not depend on any of those

the following have a wildcard too, but as it is used for all files in a folder, the * can be removed

  • cross/lirc-0.8.7/PLIST
  • cross/lirc-0.9.0/PLIST

@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js V16
2 participants
@hgy59 @th0ma7