Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy.mk: Revert change as it does not handle * PLIST entries #5046

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Jan 3, 2022

Motivation: A but was introduced in an earlier PR #5018 where PLIST entries with * are not being handled anymore.
Linked issues: #5044 (comment)

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

With d442ce2 commit I tested succesfully:

  • bazarr : Uses PLIST.auto
  • python310 (update to 3.10.1) : Uses * plist entries through cross/pip

Mandatory required for releasing

  • python310 - 3.10.1-6
  • bazarr - 1.0.2-3

@th0ma7 th0ma7 requested a review from hgy59 January 3, 2022 22:46
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 3, 2022

@hgy59 quick testing shows that this line is the culprit. Can you double-check on your side?

@th0ma7 th0ma7 self-assigned this Jan 4, 2022
@th0ma7 th0ma7 mentioned this pull request Jan 4, 2022
2 tasks
@th0ma7 th0ma7 added the bug label Jan 4, 2022
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 4, 2022

@hgy59 a second pair of eye would be appreciated as I am reverted a one-liner from your previous PR. On my side testing looked good and ready to merge.

@th0ma7 th0ma7 linked an issue Jan 4, 2022 that may be closed by this pull request
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 5, 2022

I'll be merging right away as this blocks a few pending packages to be published + I'll rebase #5050 which triggers the issue which should provide another set of confirmation that all is good.

@th0ma7 th0ma7 merged commit 35bb4d8 into SynoCommunity:master Jan 5, 2022
@th0ma7 th0ma7 deleted the copy-fix branch January 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request] Update Bazarr v1.0.2
1 participant